fix: centralize the font stack and adopt Todoist's typography defaults - #1119
Merged
Conversation
On Windows, `system-ui` resolves to the locale's UI font. Under CJK locales that is Microsoft YaHei UI, Yu Gothic UI or Malgun Gothic, so Latin text renders in a CJK UI font instead of Segoe UI. Naming 'Segoe UI' ahead of `system-ui` keeps Latin text consistent across locales while CJK characters still fall through further down the stack. Also adds BlinkMacSystemFont (Chrome on macOS), 'Noto Sans' (uncommon scripts) and 'Noto Color Emoji' (Linux/ChromeOS), and drops the Roboto/Noto/Oxygen-Sans/Ubuntu/Cantrell/'Helvetica Neue' tail that `sans-serif` already covers. This adopts todoist-web's stack, which has carried this ordering and its rationale for years, as the Reactist default. Co-Authored-By: Claude <noreply@anthropic.com>
Drops Monaco, 'Cascadia Mono' and 'Courier New', matching todoist-web's stack. Verified as a no-op for every consumer: todoist-web overrides mono globally, comms-web overrides it inside .markdown (which both of its Prose instances carry, and it has no <Box as="pre"> sites), and Automations lands on Consolas on Windows — exactly where it is today. Co-Authored-By: Claude <noreply@anthropic.com>
Both values are byte-identical overrides in todoist-web and Automations, the same duplication signal that motivated centralizing the font stack. --reactist-prose-content-font-size is additionally marked as not public API, yet two products override it — fixing the default removes the need to reach into an internal rather than blessing the practice. Note the prose change is not only text size: the variable is the base for Prose's whole vertical rhythm, so all markdown spacing rescales by 6.67%. comms-web overrides neither value and is the one consumer that moves. Co-Authored-By: Claude <noreply@anthropic.com>
frankieyan
force-pushed
the
frankie/font-stack-centralization
branch
from
July 28, 2026 05:00
72bd382 to
997e0d5
Compare
frankieyan
marked this pull request as ready for review
July 28, 2026 05:06
doistbot
reviewed
Jul 28, 2026
doistbot
left a comment
doistbot
left a comment
Member
There was a problem hiding this comment.
This PR centralizes Reactist's font stacks and aligns Prose font size and field label line heights with Todoist's typography defaults — all clean, well-scoped token changes.
Few things worth tightening:
- In
src/prose/prose.module.css, consider referencingvar(--reactist-font-size-body)instead of hardcoding14px, so Prose stays in sync if the body font-size token changes again.
I also included a few optional follow-up notes in the details below.
Optional follow-up note (1)
src/prose/prose.module.css:26: Reuse
var(--reactist-font-size-body)here instead of duplicating its current14pxvalue. The shared token already defines the body font size, and using it keeps Prose aligned if typography tokens are updated again.
frankieyan
requested review from
a team and
nats12
and removed request for
a team
July 28, 2026 05:10
Member
Author
|
FYI @pawelgrimm @benbreckler, as this will affect the size and spacing of Comms' contents, aligning them with Todoist's task descriptions/comments. |
doist-release-bot Bot
pushed a commit
that referenced
this pull request
Jul 29, 2026
## [35.0.6](v35.0.5...v35.0.6) (2026-07-29) ### Bug Fixes * centralize the font stack and adopt Todoist's typography defaults ([#1119](#1119)) ([a399aaa](a399aaa))
Contributor
|
🎉 This PR is included in version 35.0.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
This PR updates Reactist's font stacks and the base field's line heights with the values we're using in Todoist.
Size/spacing changes
Prose: Default font size is reduced from 15px to 14px, which also affects its vertical spacing (via margins and padding), since they are derived from the font sizeTextField,SelectField, etc. now specifies a 21px line-height for their labels. In Comms using theinheritdefault, this resolves to 17px, so this will render more spacing around them.Font stack changes
--reactist-font-family: the main change is placingSegoe UIahead ofsystem-ui, which makes latin text more consistent on (non macOS) systems with CJK-locales--reactist-font-family-monospace: this is better aligned with the stack Todoist/GitHub uses, and should have no visible impact on most systemsDemo
PR Checklist