Skip to content

fix: pass NPM_TOKEN to semantic-release in release workflow#1026

Merged
craigcarlyle merged 1 commit intomainfrom
fix/release-npm-token
Apr 3, 2026
Merged

fix: pass NPM_TOKEN to semantic-release in release workflow#1026
craigcarlyle merged 1 commit intomainfrom
fix/release-npm-token

Conversation

@craigcarlyle
Copy link
Copy Markdown
Contributor

@craigcarlyle craigcarlyle commented Apr 3, 2026

Summary

  • The Release step in the CI workflow was missing NODE_AUTH_TOKEN, causing semantic-release to fail with EINVALIDNPMTOKEN during the verifyConditions phase.
  • actions/setup-node creates a temporary .npmrc referencing ${NODE_AUTH_TOKEN}, but that env var was never set for the Release step.
  • Adds NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} to the Release step's environment.

Test plan

  • Merge this PR and verify the Release workflow succeeds on the resulting main commit.

Made with Cursor

@craigcarlyle
fix: pass NPM_TOKEN to semantic-release in release workflow
3b4cd5d 
The Release step was missing NODE_AUTH_TOKEN, causing npm authentication
to fail during semantic-release's verifyConditions phase.

Made-with: Cursor
@craigcarlyle craigcarlyle requested review from a team and rmartins90 and removed request for a team April 3, 2026 17:18
@craigcarlyle craigcarlyle self-assigned this Apr 3, 2026
@craigcarlyle craigcarlyle added the 👀 Show PR Used for PRs that need a review, but can be merged when CI is green. label Apr 3, 2026
@craigcarlyle craigcarlyle merged commit cc23af1 into main Apr 3, 2026
5 of 6 checks passed
@craigcarlyle craigcarlyle deleted the fix/release-npm-token branch April 3, 2026 17:20
doistbot
doistbot reviewed Apr 3, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@doistbot doistbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR provides a clear and essential fix to the CI workflow by correctly passing the NPM_TOKEN to semantic-release, successfully restoring the automated release process. The change is straightforward and well-implemented, and no issues were flagged during the review.

Share Feedback • Review Logs

doist-release-bot bot added a commit that referenced this pull request Apr 3, 2026
@doist-release-bot
chore(release): 30.1.1 [skip ci]
f18c451 
## [30.1.1](v30.1.0...v30.1.1) (2026-04-03)

### Bug Fixes

* pass NPM_TOKEN to semantic-release in release workflow ([#1026](#1026)) ([cc23af1](cc23af1))
* preserve spacing for loose lists in Prose component ([#1025](#1025)) ([67d6aae](67d6aae))
doist-release-bot bot added a commit that referenced this pull request Apr 3, 2026
@doist-release-bot
chore(release): 30.1.1 [skip ci]
a2cdb82 
## [30.1.1](v30.1.0...v30.1.1) (2026-04-03)

### Bug Fixes

* pass NPM_TOKEN to semantic-release in release workflow ([#1026](#1026)) ([cc23af1](cc23af1))
* preserve spacing for loose lists in Prose component ([#1025](#1025)) ([67d6aae](67d6aae))
* revert partial 30.1.1 release to allow clean re-release ([#1027](#1027)) ([64c6447](64c6447))
@doist-release-bot
Copy link
Copy Markdown
Contributor

doist-release-bot bot commented Apr 3, 2026

🎉 This PR is included in version 30.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@doist-release-bot doist-release-bot bot added the Released PRs that have been merged and released label Apr 3, 2026
@doistbot doistbot mentioned this pull request Apr 3, 2026
Merged
1 task
@rmartins90
Copy link
Copy Markdown
Contributor

rmartins90 commented Apr 3, 2026

✅

@henningmu
Copy link
Copy Markdown
Contributor

henningmu commented Apr 7, 2026

@rfgamaral can you double check this please? I thought we used OIDC and removed the npm tokens? 🤔

@rfgamaral
Copy link
Copy Markdown
Member

rfgamaral commented Apr 7, 2026

@rfgamaral can you double check this please? I thought we used OIDC and removed the npm tokens? 🤔

We did, but Reactist was using release-please and was recently migrated to semantic-release and something must've broken the release process. I'm on it!

@rfgamaral rfgamaral mentioned this pull request Apr 8, 2026
Merged
1 task
@rfgamaral
Copy link
Copy Markdown
Member

rfgamaral commented Apr 8, 2026

@henningmu Fixed in #1031.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@doistbot doistbot doistbot left review comments

@rmartins90 rmartins90 Awaiting requested review from rmartins90 rmartins90 was automatically assigned from Doist/frontend-product

Assignees

@craigcarlyle craigcarlyle

Labels

Released PRs that have been merged and released 👀 Show PR Used for PRs that need a review, but can be merged when CI is green.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@craigcarlyle @rmartins90 @henningmu @rfgamaral @doistbot