Conversation
utf8mb4 encoding has been used on initial DB creation for 6 years so we can drop the query on every DB connection to validate the encoding.
srjfoo
approved these changes
Sep 19, 2026
bpfoley
approved these changes
Sep 19, 2026
| throw new DBConnectionError("Database not configured for UTF8."); | ||
| } | ||
| //------------------------------------------------------------------- | ||
|
|
Collaborator
There was a problem hiding this comment.
We can drop the get_default_db_charset function and the _default_db_charset property too. This is the only place those are used. We could also restrict get_db_defaults to only SELECT DEFAULT_COLLATION_NAME.
Out of interest, how much does this query cost?
Member
Author
There was a problem hiding this comment.
We can drop the
get_default_db_charsetfunction and the_default_db_charsetproperty too. This is the only place those are used. We could also restrictget_db_defaultsto onlySELECT DEFAULT_COLLATION_NAME.
Done.
Out of interest, how much does this query cost?
Probably not very much. It's actually SELECTing into a view that joins a couple of tables but it's against data structures that I assume MySQL has in-memory.
bpfoley
approved these changes
Sep 19, 2026
chrismiceli
approved these changes
Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this is intended to be merged after the release.
utf8mb4 encoding has been used on initial DB creation for 6 years so we can drop the query on every DB connection to validate the encoding. Any user who is upgrading from a version older than R202009 must first upgrade to R202009 (per
UPGRADE.md) which has the UTF-8 conversion in it (and the last and only use of$skip_encoding_check).