PHPStan level 7: Remove several uses of stdClass in the codebase - #1644
Merged
Merged
Conversation
bpfoley
force-pushed
the
de-objectify
branch
from
September 21, 2026 20:10
a7ef8d1 to
99458e1
Compare
cpeel
self-requested a review
September 21, 2026 20:12
cpeel
reviewed
Sep 21, 2026
bpfoley
force-pushed
the
de-objectify
branch
from
September 21, 2026 20:40
99458e1 to
c585a68
Compare
cpeel
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In several places we create
stdClassobjects just to pass around some read-only data. The way they're used is only one step up from an associative array.Replace most of these with explicit DTOs, since it's so cheap to do this in PHP 8.0. They act as documentation to the developer, and both PHPStan and PHP can see their property types.