Skip to content

ENG-2118 Investigate whether to upgrade repo ESLint from version 8 to 9 #1293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
trangdoan982 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

ENG-2118 Investigate whether to upgrade repo ESLint from version 8 to 9 #1293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion apps/obsidian/eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,10 @@ import { config } from "@repo/eslint-config/react-internal";
export default [
...config,
{
files: ["**/*.{ts,tsx,mts,cts}"],
languageOptions: {
parserOptions: {
tsconfigRootDir: ".",
tsconfigRootDir: import.meta.dirname,
project: true,
ecmaFeatures: {
jsx: true,
Expand Down
3 changes: 2 additions & 1 deletion apps/roam/eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,10 @@ import { config } from "@repo/eslint-config/react-internal";
export default [
...config,
{
files: ["**/*.{ts,tsx,mts,cts}"],
languageOptions: {
parserOptions: {
tsconfigRootDir: ".",
tsconfigRootDir: import.meta.dirname,
project: true,
ecmaFeatures: {
jsx: true,
Expand Down
3 changes: 2 additions & 1 deletion apps/website/eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,10 @@ export default [
...nextJsConfig,
// additions
{
files: ["**/*.{ts,tsx,mts,cts}"],
languageOptions: {
parserOptions: {
tsconfigRootDir: ".",
tsconfigRootDir: import.meta.dirname,
project: true,
ecmaFeatures: {
jsx: true,
Expand Down
3 changes: 2 additions & 1 deletion packages/content-model/eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,11 @@ import { config as base } from "@repo/eslint-config/base";
export default [
...base,
{
files: ["**/*.{ts,tsx,mts,cts}"],
languageOptions: {
parserOptions: {
project: true,
tsconfigRootDir: ".",
tsconfigRootDir: import.meta.dirname,
},
},
},
Expand Down
3 changes: 2 additions & 1 deletion packages/database/eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,11 @@ import { config as base } from "@repo/eslint-config/base";
export default [
...base,
{
files: ["**/*.{ts,tsx,mts,cts}"],
languageOptions: {
parserOptions: {
project: true,
tsconfigRootDir: ".",
tsconfigRootDir: import.meta.dirname,
},
},
},
Expand Down
6 changes: 6 additions & 0 deletions packages/eslint-config/base.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,12 @@ export const config = [
],
},
},
{
// Plain JS files are not part of the TypeScript projects, and typescript-eslint v8
// errors instead of silently skipping them.
files: ["**/*.js", "**/*.mjs", "**/*.cjs"],
...tseslint.configs.disableTypeChecked,
},
{
ignores: [
"dist/**",
Expand Down
6 changes: 2 additions & 4 deletions packages/eslint-config/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,17 +12,15 @@
"devDependencies": {
"@eslint/js": "^9.29.0",
"@next/eslint-plugin-next": "~15.0.3",
"@vercel/style-guide": "^6.0.0",
"eslint": "catalog:",
"eslint-config-prettier": "^10.1.5",
"eslint-config-turbo": "^2.5.4",
"eslint-plugin-only-warn": "^1.1.0",
"eslint-plugin-prefer-arrow-functions": "3.4.2",
"eslint-plugin-react": "^7.37.2",
"eslint-plugin-react-hooks": "^5.2.0",
"eslint-plugin-turbo": "^2.5.4",
"eslint": "catalog:",
"globals": "16.2.0",
"typescript": "5.5.4",
"typescript-eslint": "^7.18.0"
"typescript-eslint": "^8.67.0"
}
}
3 changes: 2 additions & 1 deletion packages/ui/eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,10 @@ import { config } from "@repo/eslint-config/react-internal";
export default [
...config,
{
files: ["**/*.{ts,tsx,mts,cts}"],
languageOptions: {
parserOptions: {
tsconfigRootDir: ".",
tsconfigRootDir: import.meta.dirname,
project: true,
ecmaFeatures: {
jsx: true,
Expand Down
3 changes: 2 additions & 1 deletion packages/utils/eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,11 @@ import { config as base } from "@repo/eslint-config/base";
export default [
...base,
{
files: ["**/*.{ts,tsx,mts,cts}"],
languageOptions: {
parserOptions: {
project: true,
tsconfigRootDir: ".",
tsconfigRootDir: import.meta.dirname,
},
},
},
Expand Down
Loading