Update Node version to 22 in GitHub Actions and dependencies#1148
Update Node version to 22 in GitHub Actions and dependencies#1148mdroidian wants to merge 2 commits into
Conversation
- Updated all GitHub Actions workflows to use Node 22 instead of Node 20 - Updated @types/node from ^20 to ^22 in all package.json files - Updated engines requirement in root package.json from >=20 to >=22 - Added pnpm overrides for @types/react and @types/react-dom to resolve React 19 type conflicts - Updated pnpm lockfile to reflect the new dependencies This addresses the GitHub Actions deprecation notice for Node 20, which will be deprecated on June 16th. Node 22 is compatible with Electron 38 (used by Roam) and Electron 39 (used by Obsidian).
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR size/scope checkThis PR is over our review-size guideline.
Please split this into smaller PRs unless there is a clear reason the changes need to land together. If keeping it as one PR, please add a brief justification covering:
|
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5142a2fd83
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
The pnpm overrides forcing @types/react and @types/react-dom to v19 pulled React 19 types into the roam app (which targets React 18 via the roam catalog), surfacing removed-API errors (ReactDOM.render, JSX namespace, etc.) and failing the validate check. The overrides aren't needed for the Node 22 bump; removing them restores the catalog-based resolution used on main. Co-authored-by: linear-code[bot] <222613912+linear-code[bot]@users.noreply.github.com>
2 participants
Summary
This PR updates the Node.js version from 20 to 22 across all GitHub Actions workflows and updates the corresponding TypeScript types in package.json files.
Changes
GitHub Actions Workflows
ci.yaml(3 occurrences)roam-release.yamlroam-pr.yamlroam-main.yamldatabase-deploy.yamlNote:
test-database.yamlalready used Node 22.Package Dependencies
@types/nodefrom^20to^22in all package.json files:Root package.json
>=20to>=22@types/reactand@types/react-domto resolve React 19 type conflicts in monorepoWhy
GitHub Actions will deprecate Node 20 on June 16th, 2025 (see deprecation notice).
Node 22 is the appropriate version because:
CI Status
✅ Node 22 is working correctly in GitHub Actions - CI logs confirm
node: v22.22.3is being used.validatecheck is failing due to pre-existing React 19 migration issues in the roam package, not Node 22 compatibility issues. These errors are from using deprecated React 18 APIs (ReactDOM.render,unmountComponentAtNode) that were removed in React 19. This is a separate issue from the Node version update.All other packages build successfully:
Related
Closes ENG-1805
Linear Issue: ENG-1805