[ENG-1848] Add Roam full markdown content variant for shared nodes by sid597 · Pull Request #1134 · DiscourseGraphs/discourse-graph

sid597 · 2026-06-19T08:41:41Z

Summary

Rebases ENG-1848 on the final ENG-1847 baseline (5954c548) and keeps the ticket focused on Roam emitting the required markdown full content variant for shared nodes.

Adds convertRoamNodeToFullContent so the existing Roam sync loop uploads full content alongside the current direct content.
Keeps direct content and embedding behavior unchanged: direct rows are embedded, full rows are not embedded.
Shapes Roam full content as # {title} plus the node body via the existing toMarkdown serializer with refs/embeds inlined.
Updates the Roam reference fixture to the final CrossAppNode contract shape: CrossAppNode["content"]["full"] with inline format: "text/markdown".
Does not export or recreate the deleted draft persistence fixtures or package-level content constants.

Validation

pnpm exec prettier --check apps/roam/src/utils/convertRoamNodeToFullContent.fixture.ts apps/roam/src/utils/convertRoamNodeToFullContent.ts apps/roam/src/utils/syncDgNodesToSupabase.ts
pnpm --filter roam check-types
pnpm --filter roam lint (0 errors; existing repo warnings remain)

Manual follow-up

A real Roam graph with sync enabled still needs the Supabase smoke check: confirm a discourse node writes a variant: "full" markdown row alongside its direct content row.

linear-code · 2026-06-19T08:41:44Z

ENG-1848

supabase · 2026-06-19T08:41:46Z

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

vercel · 2026-06-19T08:41:46Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
discourse-graph	Skipped		Jun 23, 2026 9:49am

graphite-app · 2026-06-19T08:41:49Z

PR size/scope check

This PR is over our review-size guideline.

Recommended: ~200 lines changed
Acceptable limit: up to 400 lines when well-scoped/self-contained
Preferred file count: fewer than 5 files

Please split this into smaller PRs unless there is a clear reason the changes need to land together.

If keeping it as one PR, please add a brief justification covering:

What single problem this PR solves
Why the files/changes are coupled

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: add4831df7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

devin-ai-integration

Devin Review found 1 potential issue.

sid597 · 2026-06-21T20:23:07Z

Reviewer verification note:

There is no Loom for this PR because ENG-1848 has no user-facing UI surface; it adds the Roam full markdown producer plus the gated Supabase upload path.

Final-branch checks run:

pnpm exec prettier --check apps/roam/src/utils/convertRoamNodeToFullContent.ts apps/roam/src/utils/convertRoamNodeToFullContent.example.ts apps/roam/src/utils/syncDgNodesToSupabase.ts
pnpm --filter roam check-types
SUPABASE_USE_DB=local pnpm --filter roam build

The representative Roam input is captured in apps/roam/src/utils/convertRoamNodeToFullContent.example.ts from page UID dnHNmYwe5; typecheck verifies the generated markdown fits CrossAppNode["content"]["full"].

Optional historical smoke-test reproduction:

The temporary console hook used during review exists only in commit f29b4b9d and was intentionally removed in 430f0e2a.

git checkout f29b4b9d
SUPABASE_USE_DB=local pnpm --filter roam build

Then load the built Roam extension in graph plugin-testing-akamatsulab2, open page UID dnHNmYwe5, and run:

await window.dgSyncEng1848ReviewPage()

That smoke hook writes the page's full markdown row through upsert_content and reads back the matching my_contents row.

Note: the hook is not part of the final PR surface. The final branch keeps only the reusable producer/upload path, with full gated by includeFullContent: true; the real shared-node caller belongs to ENG-1851/ENG-1852.

sid597 · 2026-06-23T09:53:33Z

+  allNodes: [] as DiscourseNode[],
+};
+
+export const buildFullMarkdown = ({


This intentionally reuses Roam’s existing toMarkdown serializer instead of defining a new markdown format here. ENG-1848’s job is just to adapt Roam page/block content into the existing cross-app full markdown shape.

sid597 · 2026-06-23T09:54:32Z

+    }
+  };
+
+  if (includeFullContent) {


full is opt-in because Roam should only write the full variant for shared/published nodes. Existing background embedding sync stays direct/direct-ish only.

sid597 · 2026-06-23T09:55:24Z

+    const fullContent = convertRoamNodeToFullContent({
+      nodes: roamNodes,
+    });
+    await uploadBatches(chunk(fullContent, BATCH_SIZE));


full is uploaded before fetching embeddings so markdown persistence is not blocked by embedding service failures. Embeddings remain only on direct / direct_and_description.

sid597 · 2026-06-23T09:56:13Z

+ * node contract.
+ *
+ * Source Roam page:
+ * https://roamresearch.com/#/app/plugin-testing-akamatsulab2/page/dnHNmYwe5


This example uses the real getFullTreeByParentUid(...).children shape from the linked Roam page. We also smoke-tested that page against local Supabase and read back the expected variant = "full" markdown row.

maparent

LGTM.
Question in a line comment.

maparent · 2026-06-25T12:18:24Z

+  embeds: true,
+  simplifiedFilename: false,
+  removeSpecialCharacters: false,
+  maxFilenameLength: 64,


Curious about this value: Does it affect the title? (I expect not.) Asset filenames?

sid597 changed the base branch from main to eng-1847-define-shared-cross-app-node-content-contract June 19, 2026 08:44

chatgpt-codex-connector Bot reviewed Jun 19, 2026

View reviewed changes

Comment thread apps/roam/src/utils/syncDgNodesToSupabase.ts Outdated

Comment thread apps/roam/src/utils/convertRoamNodeToFullContent.ts

devin-ai-integration Bot reviewed Jun 19, 2026

View reviewed changes

Comment thread apps/roam/src/utils/convertRoamNodeToFullContent.ts

sid597 force-pushed the eng-1848-add-roam-full-markdown-content-variant-for-shared-nodes branch from add4831 to 43646a5 Compare June 19, 2026 10:02

vercel Bot temporarily deployed to Preview June 19, 2026 10:02 Inactive

sid597 changed the title ~~Eng 1848 add roam full markdown content variant for shared nodes~~ [ENG-1848] Add Roam full markdown content variant for shared nodes Jun 19, 2026

[ENG-1848] Add Roam full markdown content variant for shared nodes

b4f758c

sid597 force-pushed the eng-1848-add-roam-full-markdown-content-variant-for-shared-nodes branch from 43646a5 to b4f758c Compare June 19, 2026 16:37

vercel Bot temporarily deployed to Preview June 19, 2026 16:37 Inactive

sid597 changed the base branch from eng-1847-define-shared-cross-app-node-content-contract to main June 19, 2026 16:39

sid597 added 2 commits June 22, 2026 00:39

ENG-1848 Add Roam full content smoke verification

f29b4b9

ENG-1848 Remove temporary smoke test hooks

430f0e2

vercel Bot temporarily deployed to Preview June 21, 2026 19:11 Inactive

graphite-app Bot reviewed Jun 21, 2026

View reviewed changes

Comment thread apps/roam/src/utils/syncDgNodesToSupabase.ts Outdated

ENG-1848 Clean up full content comments

6ff9e81

vercel Bot temporarily deployed to Preview June 21, 2026 20:05 Inactive

ENG-1848 Gate full content uploads to shared sync

223d023

vercel Bot temporarily deployed to Preview June 22, 2026 04:03 Inactive

sid597 mentioned this pull request Jun 22, 2026

[ENG-1852] Keep Roam shared node content fresh #1147

Draft

ENG-1848 Trim review-facing cleanup

c27375d

vercel Bot temporarily deployed to Preview June 23, 2026 09:49 Inactive

sid597 commented Jun 23, 2026

View reviewed changes

sid597 requested review from maparent and mdroidian June 23, 2026 10:15

maparent approved these changes Jun 25, 2026

View reviewed changes

Uh oh!

Conversation

sid597 commented Jun 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Validation

Manual follow-up

Uh oh!

linear-code Bot commented Jun 19, 2026

Uh oh!

supabase Bot commented Jun 19, 2026

Uh oh!

vercel Bot commented Jun 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

graphite-app Bot commented Jun 19, 2026

PR size/scope check

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sid597 commented Jun 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sid597 Jun 23, 2026

Choose a reason for hiding this comment

Uh oh!

sid597 Jun 23, 2026

Choose a reason for hiding this comment

Uh oh!

sid597 Jun 23, 2026

Choose a reason for hiding this comment

Uh oh!

sid597 Jun 23, 2026

Choose a reason for hiding this comment

Uh oh!

maparent left a comment

Choose a reason for hiding this comment

Uh oh!

maparent Jun 25, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sid597 commented Jun 19, 2026 •

edited

Loading

vercel Bot commented Jun 19, 2026 •

edited

Loading

sid597 commented Jun 21, 2026 •

edited

Loading