Make iOS simulator interactive bitrate an optional cap, uncapped by default - #11
Merged
Merged
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tuning::Interactive { bitrate: None }no longer sets any rate-control property: the0.15 bppderivation (TARGET_BITS_PER_PIXEL,resolved_bitrate) is gone, and an explicitSome(bps)remains an optionalAverageBitRatecap. Low-latency rate control,RealTime,AllowFrameReordering=false,MaxFrameDelayCount=0, profile and keyframe settings are unchanged.The tuning-to-property translation is now a single seam, unit-tested:
Stats gain an additive
target_bitrate: Option<u32>(iOSStatsReport→ serve-layerStatsReport→/api/stats):Nonemeans uncapped,Somean active cap. Android mapsNone. CLI--bitratehelp andTuningdocs updated.Measurements
1206x2622 device encoding at 588x1280, screen fully covered by CSS animation, 25 s windows, no subscribers:
Session creation succeeds without
AverageBitRate, but with low-latency rate control the encoder picks an internal budget under 0.5 Mbps and drops most frames staying inside it — the capped runs sustained ~60 fps on the same stimulus. Recorded in.devin/skills/ios-simulator-video/SKILL.md. This PR ships the spec as requested (uncapped default, low-latency behaviour untouched); whether the default should change in light of these numbers is left as a follow-up decision.Checks
cargo fmt,cargo build --workspace,cargo clippy --workspace --all-targets(only pre-existing warnings),cargo test --workspace --lib,cargo test -p accessibility-cli --test cli_smoke— all green.Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/50a3e0f756984f20a1779e22d438ce96
Open in Devin Desktop: https://dioxus.staging.devinenterprise.com/desktop/session/50a3e0f756984f20a1779e22d438ce96?variant=devin-insiders
Requested by: @jkelleyrtp