Skip to content

chore(charts): charts to deploy auth-broker#1456

Open
davehadley wants to merge 1 commit into
mainfrom
drh/auth-broker-charts
Open

chore(charts): charts to deploy auth-broker#1456
davehadley wants to merge 1 commit into
mainfrom
drh/auth-broker-charts

Conversation

@davehadley

Copy link
Copy Markdown
Collaborator

No description provided.

@davehadley
davehadley force-pushed the drh/auth-broker-charts branch 3 times, most recently from 9a13842 to 46f0457 Compare July 20, 2026 06:37
@davehadley
davehadley force-pushed the drh/auth-broker-charts branch from 46f0457 to 43661af Compare July 20, 2026 06:46
@davehadley
davehadley marked this pull request as ready for review July 20, 2026 06:53

@JamesDoingStuff JamesDoingStuff left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, minor comments in code

Comment thread charts/apps/Chart.yaml
description: An argocd app to deploy apps inside the virtual cluster
type: application
version: 0.5.9
version: 0.5.11

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for 0.5.11 instead of .10?

enabled: true
targetRevision: HEAD
extraValuesFiles: []
valuesObject: {} No newline at end of file

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing newline

})
})
]
) No newline at end of file

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing newline

Comment thread charts/auth-broker/staging-values.yaml
@@ -0,0 +1,3 @@
image:
tag: drh
pullPolicy: Always No newline at end of file

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing newline

@@ -0,0 +1,99 @@
{{- $root := . -}}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused variable?

name: auth-keys
namespace: workflows
type: Opaque
{{- end }} No newline at end of file

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing newline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants