Skip to content

Another general tidy PR - #259

Open
OCopping wants to merge 5 commits into
mainfrom
general-tidy
Open

Another general tidy PR#259
OCopping wants to merge 5 commits into
mainfrom
general-tidy

Conversation

@OCopping

Copy link
Copy Markdown
Collaborator

No description provided.

@OCopping
OCopping force-pushed the general-tidy branch 2 times, most recently from e1d9938 to 9405159 Compare July 28, 2026 10:02
@codecov

codecov Bot commented Jul 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 84.21053% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.03%. Comparing base (7c4839a) to head (ff196ec).

Files with missing lines Patch % Lines
src/techui_builder/models.py 80.00% 2 Missing ⚠️
src/techui_builder/builder.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #259      +/-   ##
==========================================
- Coverage   96.07%   96.03%   -0.04%     
==========================================
  Files          13       13              
  Lines         994      984      -10     
==========================================
- Hits          955      945      -10     
  Misses         39       39              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread tests/test_models.py

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please can you explain why these have been removed?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On removing the Types and Models in models.py, We used to have the models for the entities created by builder be of the type GuiComponents, but with the change in the structure of the techui-support.yaml - which the entities are created from, we have had to switch to using a new model called TechUiSupport, also located in models, which closely mirrors the structure of the new techui-support.yaml. With this removed, the tests that concern the GuiComponents have been removed as well.

These old models are no longer needed with the addition of the
TechUiSupport model, as they basically do the same thing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants