Moved logging, and removed old supportyaml model; modified tests.#235
Open
adedamola-sode wants to merge 5 commits into
Open
Moved logging, and removed old supportyaml model; modified tests.#235adedamola-sode wants to merge 5 commits into
adedamola-sode wants to merge 5 commits into
Conversation
Collaborator
adedamola-sode
commented
Jun 4, 2026
- moved logging from main_app.py to main.py
- removed old techui-support mapping model from models.py, and changed schema generation from the old one
- adjusted model tests
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #235 +/- ##
==========================================
- Coverage 96.25% 96.09% -0.17%
==========================================
Files 13 13
Lines 962 948 -14
==========================================
- Hits 926 911 -15
- Misses 36 37 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
OCopping
requested changes
Jun 4, 2026
OCopping
requested changes
Jun 4, 2026
updated docstring Co-authored-by: Ollie Copping <oliver.copping@diamond.ac.uk>
7d927dc to
3591e7e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.