Skip to content

Add logic to correctly register '_Lng_SVCC' denoised datasets as well #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tieneupin wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add logic to correctly register '_Lng_SVCC' denoised datasets as well #813

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/murfey/workflows/clem/register_preprocessing_results.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,11 +59,13 @@ class CLEMPreprocessingResult(BaseModel):
@cached_property
def is_denoised(self) -> bool:
"""
The "_Lng_LVCC" suffix appended to a CLEM dataset's position name indicates
that it's a denoised image set of the same position. These results should
override or supersede the original ones once they're available.
The "_Lng_LVCC" and "_Lng_SVCC" suffixes appended to a CLEM dataset's position
name indicate that it's a denoised image set of the same position. They should
override or supersede the original ones if they're present
"""
return "_Lng_LVCC" in self.series_name
return any(
pattern in self.series_name for pattern in ("_Lng_LVCC", "_Lng_SVCC")
)

# Valid Pydantic decorator not supported by MyPy
@computed_field # type: ignore
Expand All @@ -73,7 +75,7 @@ def site_name(self) -> str:
Extract just the name of the site by removing the "_Lng_LVCC" suffix from
the series name.
"""
return self.series_name.replace("_Lng_LVCC", "")
return self.series_name.replace("_Lng_LVCC", "").replace("_Lng_SVCC", "")

# Valid Pydantic decorator not supported by MyPy
@computed_field # type: ignore
Expand Down