Register FIB data in ISPyB#805
Merged
Merged
Conversation
tieneupin
force-pushed
the
register-fib-ispyb-data
branch
2 times, most recently
from
7c7f895 to
c747bfb
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
tieneupin
force-pushed
the
register-fib-ispyb-data
branch
from
c747bfb to
67bf24f
Compare
…t the end of the function, and both new and old entries are populated or updated correctly
tieneupin
force-pushed
the
register-fib-ispyb-data
branch
from
67bf24f to
409f9a4
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #805 +/- ##
==========================================
+ Coverage 52.20% 52.39% +0.19%
==========================================
Files 96 97 +1
Lines 10379 10461 +82
Branches 1373 1381 +8
==========================================
+ Hits 5418 5481 +63
- Misses 4677 4691 +14
- Partials 284 289 +5 🚀 New features to boost your workflow:
|
… using FIB atlas data
tieneupin
force-pushed
the
register-fib-ispyb-data
branch
from
949aa3c to
df5c51a
Compare
tieneupin
force-pushed
the
register-fib-ispyb-data
branch
from
df5c51a to
06d9cac
Compare
tieneupin
added
enhancement
… needed for one function
stephen-riggs
approved these changes
May 28, 2026
Contributor
stephen-riggs
left a comment
stephen-riggs
left a comment
There was a problem hiding this comment.
This all looks like it will work, just a few queries about the structure
…nd run through the RabbitMQ feedback queue instead of being loaded directly
…ib_atlas' API endpoint
stephen-riggs
approved these changes
May 29, 2026
Contributor
stephen-riggs
left a comment
stephen-riggs
left a comment
There was a problem hiding this comment.
Thanks for addressing my comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the existing FIB data registration workflow to insert a DataCollectionGroup and Atlas into ISPyB for each unique sample detected.
Currently inserts the path to the real image, as thumbnail generation logic hasn't been implemented yet.