Conversation
| millingStepId int(11) unsigned PRIMARY KEY AUTO_INCREMENT, | ||
| millingStepNameId int(11) unsigned, | ||
| isEnabled tinyint(1) DEFAULT 0 COMMENT "This marks whether the milling step is enabled and queued up; when the FIB starts this step, it will be set to False", | ||
| status enum("Finished", "Failed", "Aborted") COMMENT "Describes the status of the milling step", |
There was a problem hiding this comment.
"None" also appears in the metadata as a possible string literal. Would you rather we insert null instead of "None" in that instance?
Also, correct me if I'm wrong, but if status was previously populated with a string, we can set it to null again, right?
There was a problem hiding this comment.
Oh yes, I though that when you mentioned "None", it was functionally equivalent to "null", but if there is some distinction, I can readd it
Status should only accept enums, so since the table doesn't exist yet, it'll only accept enums
Also, I remember there was one column in GridSquare that you may want to add, is that still the case?
There was a problem hiding this comment.
there was one column in GridSquare that you may want to add
Looking back on our previous chats, I think we no longer need that for this batch of changes.
Status should only accept enums
Ah, I see. Unselected steps will have "None" as their activity status, and there might be an off chance that something will go from one of the known options back to "None". The status column would thus need to support the insertion of null, "None", or "", whichever one is easier from an SQL perspective.
There was a problem hiding this comment.
All of them are equally easy, it remains nullable, so you'll be able to set it to "null" and enums, but not strings
There was a problem hiding this comment.
OK, thanks for clarifying! We can go with the null option, then.
tieneupin
left a comment
tieneupin
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks for doing this!
2 participants
No description provided.