N4ce extensions: curves.hlsl - #1089
Merged
Merged
Conversation
Comment on lines
+670
to
+675
| namespace en | ||
| { | ||
| namespace nabla2d | ||
| { | ||
| namespace curves | ||
| { |
Contributor
There was a problem hiding this comment.
oops, you brought other stuff you weren't supposed to.
these weren't in nbl::ext
| namespace curves | ||
| { | ||
|
|
||
| namespace impl |
Contributor
There was a problem hiding this comment.
we should expose these, don't put in impl
Comment on lines
+460
to
+485
| // TODO: should it stay in this header? | ||
| #include <nbl/builtin/hlsl/concepts.hlsl> | ||
| // declare concept | ||
| #define NBL_CONCEPT_NAME BezierAdder | ||
| #define NBL_CONCEPT_TPLT_PRM_KINDS (typename)(typename)(int32_t)(int32_t) | ||
| #define NBL_CONCEPT_TPLT_PRM_NAMES (U)(T)(Dims)(Components) | ||
| // not the greatest syntax but works | ||
| #define NBL_CONCEPT_PARAM_0 (a,U) | ||
| #define NBL_CONCEPT_PARAM_1 (uv,vector<uint16_t,Dims>) | ||
| #define NBL_CONCEPT_PARAM_2 (layer,uint16_t) | ||
| #define NBL_CONCEPT_PARAM_3 (data,vector<T,Components>) | ||
| // start concept | ||
| NBL_CONCEPT_BEGIN(4) | ||
| // need to be defined AFTER the cocnept begins | ||
| #define a NBL_CONCEPT_PARAM_T NBL_CONCEPT_PARAM_0 | ||
| #define uv NBL_CONCEPT_PARAM_T NBL_CONCEPT_PARAM_1 | ||
| #define layer NBL_CONCEPT_PARAM_T NBL_CONCEPT_PARAM_2 | ||
| #define data NBL_CONCEPT_PARAM_T NBL_CONCEPT_PARAM_3 | ||
| NBL_CONCEPT_END( | ||
| ((NBL_CONCEPT_REQ_EXPR)(a.template set<T,Dims>(uv,layer,data))) | ||
| ); | ||
| #undef data | ||
| #undef layer | ||
| #undef uv | ||
| #undef a | ||
| #include <nbl/builtin/hlsl/concepts/__end.hlsl> |
Contributor
There was a problem hiding this comment.
what's data, uv, layer?
remove if unrelated and half-done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.