Skip to content

feat(dgw): provision the target-side KDC for credential injection #1865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
irvingouj@Devolutions (irvingoujAtDevolution) wants to merge 5 commits into from
Open

feat(dgw): provision the target-side KDC for credential injection #1865

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8ba1c4e
refactor(dgw): move credential-injection KDC into a generic provision…
irvingoujAtDevolution Jul 24, 2026
4def9b7
refactor(dgw): scope the provisioning store to the crate
irvingoujAtDevolution Jul 24, 2026
d76a165
refactor(dgw): split credential injection into provisioning and KDC s…
irvingoujAtDevolution Jul 24, 2026
bc71a43
refactor(dgw): rename KDC service and validate target options at cons…
irvingoujAtDevolution Jul 24, 2026
5c7ef68
fix(dgw): validate the provisioned KDC address at construction
irvingoujAtDevolution Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions devolutions-gateway/openapi/doc/index.adoc
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions devolutions-gateway/openapi/dotnet-client/.openapi-generator/FILES
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ docs/SessionsApi.md
docs/SetConfigResponse.md
docs/SubProvisionerKey.md
docs/Subscriber.md
docs/TargetConnectionOptions.md
docs/TrafficApi.md
docs/TrafficEventResponse.md
docs/TransportProtocolResponse.md
Expand Down Expand Up @@ -128,5 +129,6 @@ src/Devolutions.Gateway.Client/Model/SessionTokenSignRequest.cs
src/Devolutions.Gateway.Client/Model/SetConfigResponse.cs
src/Devolutions.Gateway.Client/Model/SubProvisionerKey.cs
src/Devolutions.Gateway.Client/Model/Subscriber.cs
src/Devolutions.Gateway.Client/Model/TargetConnectionOptions.cs
src/Devolutions.Gateway.Client/Model/TrafficEventResponse.cs
src/Devolutions.Gateway.Client/Model/TransportProtocolResponse.cs
1 change: 1 addition & 0 deletions devolutions-gateway/openapi/dotnet-client/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,7 @@ Class | Method | HTTP request | Description
- [Model.SetConfigResponse](docs/SetConfigResponse.md)
- [Model.SubProvisionerKey](docs/SubProvisionerKey.md)
- [Model.Subscriber](docs/Subscriber.md)
- [Model.TargetConnectionOptions](docs/TargetConnectionOptions.md)
- [Model.TrafficEventResponse](docs/TrafficEventResponse.md)
- [Model.TransportProtocolResponse](docs/TransportProtocolResponse.md)

Expand Down
1 change: 1 addition & 0 deletions devolutions-gateway/openapi/dotnet-client/docs/PreflightOperation.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 9 additions & 0 deletions devolutions-gateway/openapi/dotnet-client/docs/TargetConnectionOptions.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 11 additions & 1 deletion ...-gateway/openapi/dotnet-client/src/Devolutions.Gateway.Client/Model/PreflightOperation.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

90 changes: 90 additions & 0 deletions ...way/openapi/dotnet-client/src/Devolutions.Gateway.Client/Model/TargetConnectionOptions.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 14 additions & 0 deletions devolutions-gateway/openapi/gateway-api.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1772,6 +1772,10 @@ components:
- id
- kind
properties:
connection_options:
allOf:
- $ref: '#/components/schemas/TargetConnectionOptions'
nullable: true
host_to_resolve:
type: string
description: |-
Expand Down Expand Up @@ -2105,6 +2109,16 @@ components:
Url:
type: string
description: HTTP URL where notification messages are to be sent
TargetConnectionOptions:
type: object
properties:
krb_kdc:
type: string
description: |-
Kerberos KDC address for the target-side CredSSP connection.

Supported schemes are `tcp` and `udp`.
nullable: true
TrafficEventResponse:
type: object
required:
Expand Down
1 change: 1 addition & 0 deletions devolutions-gateway/openapi/ts-angular-client/.openapi-generator/FILES
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ model/sessionTokenSignRequest.ts
model/setConfigResponse.ts
model/subProvisionerKey.ts
model/subscriber.ts
model/targetConnectionOptions.ts
model/trafficEventResponse.ts
model/transportProtocolResponse.ts
ng-package.json
Expand Down
1 change: 1 addition & 0 deletions devolutions-gateway/openapi/ts-angular-client/model/models.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions devolutions-gateway/openapi/ts-angular-client/model/preflightOperation.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 20 additions & 0 deletions devolutions-gateway/openapi/ts-angular-client/model/targetConnectionOptions.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 5 additions & 2 deletions devolutions-gateway/src/api/kdc_proxy.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ pub fn make_router<S>(state: DgwState) -> Router<S> {
async fn kdc_proxy(
State(DgwState {
conf_handle,
credentials,
credential_injection,
provisioning,
agent_tunnel_handle,
..
}): State<DgwState>,
Expand All @@ -47,7 +48,9 @@ async fn kdc_proxy(
KdcDestination::Inject { jti } => {
enforce_credential_injection_enabled(jti, conf.debug.enable_unstable)?;

let kdc = credentials.kdc_for(jti).map_err(credential_injection_resolve_error)?;
let kdc = credential_injection
.kdc_for(&provisioning, jti)
.map_err(credential_injection_resolve_error)?;

debug!(
jti = %kdc.jti(),
Expand Down
Loading
Loading