refactor(agent): remove vestigial hubs from PSU gRPC protocol#1858
Open
Benoît Cortier (CBenoit) wants to merge 2 commits into
Open
refactor(agent): remove vestigial hubs from PSU gRPC protocol#1858Benoît Cortier (CBenoit) wants to merge 2 commits into
Benoît Cortier (CBenoit) wants to merge 2 commits into
Conversation
The PSU agent gRPC protocol carried a hubs label on registration that the server echoed back, ported mechanically from the older SignalR PSUEventHub protocol. It is vestigial: agent identity is defined by AgentId and job fan-out is handled by computer groups, which superseded hubs. Remove the hubs and accepted_hubs fields from the protocol and every producer, along with the related POC container configuration. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H56zawifWCep1KFqMiDdD9
Contributor
There was a problem hiding this comment.
Pull request overview
Removes vestigial PSU hub metadata from the agent’s gRPC protocol and configuration.
Changes:
- Removes
hubsandaccepted_hubsprotocol fields. - Removes hub configuration from agent runtime and tests.
- Cleans up POC container scripts and environment variables.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
devolutions-agent/src/psu_agent/mod.rs |
Stops sending hubs during registration. |
devolutions-agent/src/config.rs |
Removes hub configuration. |
devolutions-agent/Run-PsuGrpcAgentContainer.ps1 |
Removes the container hubs parameter. |
devolutions-agent/proto/psu_agent.proto |
Removes obsolete protocol fields. |
devolutions-agent/Dockerfile.psu-grpc-poc |
Removes the hubs environment variable. |
devolutions-agent/docker/psu-grpc-entrypoint.sh |
Removes hub parsing and JSON generation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Benoît Cortier (CBenoit)
enabled auto-merge (squash)
July 17, 2026 06:42
Removing the hubs field left a gap at tag 9 in RegisterAgent. Renumber the trailing fields (capabilities 10->9, powershell_runtimes 11->10) so the field numbering is contiguous again. Wire-format change, safe for this POC protocol since both ends are updated together. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H56zawifWCep1KFqMiDdD9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PSU agent gRPC protocol carried a hubs label on registration that the
server echoed back, ported mechanically from the older SignalR PSUEventHub
protocol. It is vestigial: agent identity is defined by AgentId and job
fan-out is handled by computer groups, which superseded hubs.