fix(pdu): scope Font Map leniency - #1506
Merged
Merged
Conversation
Only default a fully empty Server Font Map body at ShareDataPdu dispatch. Keep the shared FontPdu decoder strict so a header-only client Font List is rejected. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Marc-André Moreau (mamoreau-devolutions)
July 31, 2026 17:41
View session
github-actions
Bot
added
A-core
Contributor
There was a problem hiding this comment.
Pull request overview
Scopes empty-body tolerance to Server Font Map decoding while preserving strict Font List validation.
Changes:
- Defaults empty Font Map bodies to
FontPdu::default(). - Adds regression coverage for accepted Font Maps and rejected Font Lists.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
crates/ironrdp-pdu/src/rdp/headers.rs |
Adds scoped Font Map leniency. |
crates/ironrdp-testsuite-core/tests/pdu/rdp.rs |
Adds header-only decoding tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Benoît Cortier (CBenoit)
changed the title
Benoît Cortier (CBenoit)
approved these changes
Jul 31, 2026
Marc-André Moreau (mamoreau-devolutions)
added a commit
that referenced
this pull request
Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Supersedes #1472. The prior approach made
FontPdu::decodeaccept empty input, butFontPduis shared by Font List and Font Map. A malformed header-only client Font List could therefore decode successfully and advance acceptor finalization.This PR keeps
FontPdu::decodestrict and defaults only a fully empty Server Font Map body in theShareDataPduType::FontMapdispatch arm. Header-only Font Map decoding succeeds withFontPdudefaults; header-only Font List remains rejected.Tests
cargo test -p ironrdp-testsuite-core --test integration_tests_core pdu::rdpcargo clippy -p ironrdp-pdu --all-targets -- -D warnings