fix(session): handle bitmap updates wider than the destination rectangle - #1452
Closed
Viktor Liu (lixmal) wants to merge 1 commit into
Closed
fix(session): handle bitmap updates wider than the destination rectangle#1452Viktor Liu (lixmal) wants to merge 1 commit into
Viktor Liu (lixmal) wants to merge 1 commit into
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
process_bitmap_update()Some servers, like xrdp, round the bitmap width in a Bitmap Update up to a multiple of 4, so the width can be bigger than the destination rectangle. The apply functions use the rectangle width as the row stride, so the extra padding columns push every following row over and the image comes out sheared.
Relates to
Validation
cargo xtask check fmt -vcargo xtask check lints -v