Create memory-bytes-for-each-file.md#9
Create memory-bytes-for-each-file.md#9DeveloperTryingToCodeLikeOtherOfThem wants to merge 3 commits intomasterfrom
Conversation
Summary of ChangesHello @DeveloperTryingToCodeLikeOtherOfThem, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new documentation page that aims to clarify how memory usage for files can be estimated. The document explains the fundamental concept of character-based storage and provides a simple example to illustrate how to think about the byte requirements for digital content. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a new documentation file, memory-bytes-for-each-file.md. The current content has several grammatical errors, typos, and is generally unclear, which could confuse readers. I've provided a suggestion to rewrite the entire file to improve its clarity, grammar, and technical accuracy.
| ## How many bytes is enough for creating the file unit precisely | ||
|
|
||
| To know how many memory is enough for that file, you need to think how many charcaters or punctuation is inserted in the document like word | ||
| that needs to be stored in the file you were writing. For instance, think of it like how many charcaters are there in the, 3 characters right because | ||
| they are t, h, and e that forms the whole word "the". The same thing for computers, they read by how many digits or charcaters that form the whole word | ||
| in the end. Use regular bytes for very simple projects like for example, the file has only a 160 * 120 screen in total are and store all the bits per pixel | ||
| filling the screen by doing this because it is simple, it is just storing individual bits into the screen. |
There was a problem hiding this comment.
The content of this new file has several grammatical errors, typos (e.g., 'charcaters'), and unclear phrasing that make it difficult to understand. The title is also a bit awkward. I recommend rewriting the content to be more clear, concise, and grammatically correct.
| ## How many bytes is enough for creating the file unit precisely | |
| To know how many memory is enough for that file, you need to think how many charcaters or punctuation is inserted in the document like word | |
| that needs to be stored in the file you were writing. For instance, think of it like how many charcaters are there in the, 3 characters right because | |
| they are t, h, and e that forms the whole word "the". The same thing for computers, they read by how many digits or charcaters that form the whole word | |
| in the end. Use regular bytes for very simple projects like for example, the file has only a 160 * 120 screen in total are and store all the bits per pixel | |
| filling the screen by doing this because it is simple, it is just storing individual bits into the screen. | |
| ## How Many Bytes Does a File Need? | |
| To determine how much memory a file requires, you need to consider its contents. For example, in a text file, the size is determined by the number of characters (including spaces and punctuation). Each character typically requires one or more bytes of storage. | |
| For other types of files, like images, the calculation is different. For an image on a 160x120 pixel screen, the total memory needed would be the total number of pixels (160 * 120) multiplied by the number of bytes required to store the color of each pixel (which depends on the bits per pixel, or BPP). |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bc3693c3da
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| To know how many memory is enough for that file, you need to think how many charcaters or punctuation is inserted in the document like word | ||
| that needs to be stored in the file you were writing. For instance, think of it like how many charcaters are there in the, 3 characters right because | ||
| they are t, h, and e that forms the whole word "the". The same thing for computers, they read by how many digits or charcaters that form the whole word |
There was a problem hiding this comment.
This explanation equates file size to the number of “characters,” which only holds for single‑byte encodings and ASCII‑only content. If a reader stores any non‑ASCII text (e.g., accented letters, emoji, or non‑Latin scripts) in UTF‑8, each character can take multiple bytes, so counting characters will underestimate required memory. Consider explicitly stating that bytes per character depend on the file’s encoding and content.
Useful? React with 👍 / 👎.
| in the end. Use regular bytes for very simple projects like for example, the file has only a 160 * 120 screen in total are and store all the bits per pixel | ||
| filling the screen by doing this because it is simple, it is just storing individual bits into the screen. |
There was a problem hiding this comment.
The 160×120 example suggests storing “individual bits” for the screen, which is only correct for a 1‑bit monochrome framebuffer. Most displays use at least 8‑ or 16‑bit color, so memory sizing must be width × height × bytes_per_pixel (e.g., 160×120×2 bytes for 16‑bit color). As written, this would mislead readers into under‑allocating memory unless they explicitly use 1‑bpp storage.
Useful? React with 👍 / 👎.
…loperTryingToCodeLikeOtherOfThem-patch-7 Update memory-bytes-for-each-file.md
1 participant
No description provided.