Quality: getTabById returns undefined when tab not found despite non-nullable return type#8543
Open
kumburovicbranko682-boop wants to merge 1 commit into
Conversation
…spite non-nullable return type `Array.prototype.find()` returns `undefined` when no element matches, but the function declares its return type as `Promise<TargetInfo>` (non-nullable). The `as TargetInfo` cast silences the compiler but doesn't prevent `undefined` at runtime. Any caller accessing properties on the result (e.g., `tab.url`, `tab.webSocketDebuggerUrl`) will get a TypeError: "Cannot read properties of undefined". This is especially likely during race conditions where a tab closes between `getTabs` and the caller using the result. Affected files: utils.ts Signed-off-by: kumburovicbranko682-boop <295886834+kumburovicbranko682-boop@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Code Quality
Problem
Array.prototype.find()returnsundefinedwhen no element matches, but the function declares its return type asPromise<TargetInfo>(non-nullable). Theas TargetInfocast silences the compiler but doesn't preventundefinedat runtime. Any caller accessing properties on the result (e.g.,tab.url,tab.webSocketDebuggerUrl) will get a TypeError: "Cannot read properties of undefined". This is especially likely during race conditions where a tab closes betweengetTabsand the caller using the result.Severity:
highFile:
src/browser/provider/built-in/dedicated/chrome/cdp-client/utils.tsSolution
export async function getTabById (port: number, id: string): Promise<TargetInfo | undefined> {
const tabs = await getTabs(port);
}
// Or throw explicitly:
export async function getTabById (port: number, id: string): Promise {
const tabs = await getTabs(port);
const tab = tabs.find(tab => tab.id === id);
}
Changes
src/browser/provider/built-in/dedicated/chrome/cdp-client/utils.ts(modified)Purpose
Describe the problem you want to address or the feature you want to implement.
Approach
Describe how your changes address the issue or implement the desired functionality in as much detail as possible.
References
Provide a link to the existing issue(s), if any.
Pre-Merge TODO
🤖 About this PR
This pull request was generated by ContribAI, an AI agent
that helps improve open source projects. The change was:
If you have questions or feedback about this PR, please comment below.
We appreciate your time reviewing this contribution!
Closes #8542