Scheduler — Refactor scheduler.d.ts file#34342
Closed
sjbur wants to merge 12 commits into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the Scheduler TypeScript declaration surface to use the standardized Properties/Item type exports (instead of legacy dx*Options/dx*Item names) and cleans up redundant JSDoc @type tags in scheduler.d.ts. These changes primarily aim to modernize and normalize the public typings across the source .d.ts, the bundled dx.all.d.ts, and the generated Vue wrapper.
Changes:
- Switched
dxScheduler’s generic option type toPropertiesand updated DateNavigator button group typing to usedxButtonGroup.Properties/dxButtonGroup.Item. - Removed redundant JSDoc
@type ...annotations where TypeScript types already describe the same information. - Updated generated Vue Scheduler wrapper prop typings accordingly.
Reviewed changes
Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/devextreme/ts/dx.all.d.ts | Aligns bundled Scheduler typings with DevExpress.ui.dxScheduler.Properties and updated DateNavigator button group types. |
| packages/devextreme/js/ui/scheduler.d.ts | Refactors Scheduler public typings to use Properties/Item imports and cleans up redundant JSDoc @type tags. |
| packages/devextreme-vue/src/scheduler.ts | Updates generated Vue wrapper prop unions to match the refactored Scheduler/ButtonGroup typings. |
mpreyskurantov
requested changes
Jul 17, 2026
mpreyskurantov
left a comment
mpreyskurantov
left a comment
Contributor
There was a problem hiding this comment.
check docs generation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.