PivotGrid - KBN - Add ARIA attributes to area fields#34341
Open
aleksei-semikozov wants to merge 2 commits into
Open
PivotGrid - KBN - Add ARIA attributes to area fields#34341aleksei-semikozov wants to merge 2 commits into
aleksei-semikozov wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances PivotGrid (and the PivotGrid Field Chooser) keyboard-navigation accessibility by exposing area field containers as menubars and individual fields as menu items with localized ARIA labels, plus accompanying unit/e2e coverage.
Changes:
- Update PivotGrid FieldsArea markup to conditionally expose populated areas as a labelled menubar while keeping empty areas presentational.
- Add per-field
role="menuitem"and computedaria-labelthat reflects caption + sort/header-filter state. - Add new localization message keys and extend QUnit/Jest/TestCafe coverage for the updated ARIA semantics.
Reviewed changes
Copilot reviewed 43 out of 43 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/devextreme/testing/tests/DevExpress.ui.widgets.pivotGrid/pivotGrid.markup.tests.js | Updates accessibility markup assertions for menubar behavior and empty filter-area behavior. |
| packages/devextreme/js/localization/messages/ar.json | Adds new PivotGrid ARIA message keys. |
| packages/devextreme/js/localization/messages/bg.json | Adds new PivotGrid ARIA message keys. |
| packages/devextreme/js/localization/messages/ca.json | Adds new PivotGrid ARIA message keys. |
| packages/devextreme/js/localization/messages/cs.json | Adds new PivotGrid ARIA message keys. |
| packages/devextreme/js/localization/messages/da.json | Adds new PivotGrid ARIA message keys. |
| packages/devextreme/js/localization/messages/de.json | Adds new PivotGrid ARIA message keys. |
| packages/devextreme/js/localization/messages/el.json | Adds new PivotGrid ARIA message keys. |
| packages/devextreme/js/localization/messages/en.json | Adds new PivotGrid ARIA message keys. |
| packages/devextreme/js/localization/messages/es.json | Adds new PivotGrid ARIA message keys. |
| packages/devextreme/js/localization/messages/fa.json | Adds new PivotGrid ARIA message keys. |
| packages/devextreme/js/localization/messages/fi.json | Adds new PivotGrid ARIA message keys. |
| packages/devextreme/js/localization/messages/fr.json | Adds new PivotGrid ARIA message keys. |
| packages/devextreme/js/localization/messages/hi.json | Adds new PivotGrid ARIA message keys. |
| packages/devextreme/js/localization/messages/hu.json | Adds new PivotGrid ARIA message keys. |
| packages/devextreme/js/localization/messages/it.json | Adds new PivotGrid ARIA message keys. |
| packages/devextreme/js/localization/messages/ja.json | Adds new PivotGrid ARIA message keys. |
| packages/devextreme/js/localization/messages/ko.json | Adds new PivotGrid ARIA message keys. |
| packages/devextreme/js/localization/messages/lt.json | Adds new PivotGrid ARIA message keys. |
| packages/devextreme/js/localization/messages/lv.json | Adds new PivotGrid ARIA message keys. |
| packages/devextreme/js/localization/messages/nb.json | Adds new PivotGrid ARIA message keys. |
| packages/devextreme/js/localization/messages/nl.json | Adds new PivotGrid ARIA message keys. |
| packages/devextreme/js/localization/messages/pl.json | Adds new PivotGrid ARIA message keys. |
| packages/devextreme/js/localization/messages/pt.json | Adds new PivotGrid ARIA message keys. |
| packages/devextreme/js/localization/messages/pt-PT.json | Adds new PivotGrid ARIA message keys. |
| packages/devextreme/js/localization/messages/pt-BR.json | Adds new PivotGrid ARIA message keys. |
| packages/devextreme/js/localization/messages/ro.json | Adds new PivotGrid ARIA message keys. |
| packages/devextreme/js/localization/messages/ru.json | Adds new PivotGrid ARIA message keys. |
| packages/devextreme/js/localization/messages/sl.json | Adds new PivotGrid ARIA message keys. |
| packages/devextreme/js/localization/messages/sv.json | Adds new PivotGrid ARIA message keys. |
| packages/devextreme/js/localization/messages/tr.json | Adds new PivotGrid ARIA message keys. |
| packages/devextreme/js/localization/messages/uk.json | Adds new PivotGrid ARIA message keys. |
| packages/devextreme/js/localization/messages/vi.json | Adds new PivotGrid ARIA message keys. |
| packages/devextreme/js/localization/messages/zh.json | Adds new PivotGrid ARIA message keys. |
| packages/devextreme/js/localization/messages/zh-tw.json | Adds new PivotGrid ARIA message keys. |
| packages/devextreme/js/localization/messages/zh-Hans.json | Adds new PivotGrid ARIA message keys. |
| packages/devextreme/js/localization/messages/zh-CN.json | Adds new PivotGrid ARIA message keys. |
| packages/devextreme/js/__internal/grids/pivot_grid/fields_area/m_fields_area.ts | Implements conditional menubar exposure for populated PivotGrid field areas and presentational markup for empty areas. |
| packages/devextreme/js/__internal/grids/pivot_grid/field_chooser/m_field_chooser.ts | Applies conditional menubar role + aria-label to FieldChooser area containers only when fields are present. |
| packages/devextreme/js/__internal/grids/pivot_grid/field_chooser/m_field_chooser_base.ts | Sets role="menuitem" and computed aria-label on rendered field items. |
| packages/devextreme/js/__internal/grids/pivot_grid/field_chooser/a11y.ts | Introduces helper for composing localized field aria-labels with sort/filter state. |
| packages/devextreme/js/__internal/grids/pivot_grid/field_chooser/a11y.test.ts | Adds Jest coverage for aria-label composition logic. |
| e2e/testcafe-devextreme/tests/common/pivotGrid/kbn/fields.ts | Adds E2E assertions for menubar/menuitem roles and composed field aria-labels. |
vladaskorohodova
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.