T1303892 - DataGrid - Drag icon is vertically misaligned if column fixing is enabled in Generic Themes#34315
Open
bit-byte0 wants to merge 5 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes vertical alignment of the row-drag handle icon in DataGrid/TreeList when sticky (fixed) columns are present, by excluding drag-command cells from sticky-columns padding compensation across supported themes. Also adds visual coverage and a Storybook scenario for review.
Changes:
- Exclude
.dx-command-dragcells from sticky-columns padding compensation in generic, material, and fluent grid base cell layouts. - Add a TestCafe screenshot test validating drag-icon centering in focused/selected rows.
- Add a React Storybook example intended to showcase row dragging with column fixing.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/devextreme-scss/scss/widgets/material/gridBase/layout/cell.scss | Excludes drag-command cells from sticky-columns padding compensation in Material theme. |
| packages/devextreme-scss/scss/widgets/generic/gridBase/layout/cell.scss | Excludes drag-command cells from sticky-columns padding compensation in Generic theme. |
| packages/devextreme-scss/scss/widgets/fluent/gridBase/layout/cell.scss | Excludes drag-command cells from sticky-columns padding compensation in Fluent theme. |
| e2e/testcafe-devextreme/tests/dataGrid/sticky/common/withDragAndDrop.ts | Adds screenshot test for drag icon alignment under sticky columns + focus/selection. |
| apps/react-storybook/stories/examples/datagrid/DataGrid.stories.tsx | Adds Storybook story for designer review of the row-dragging + column fixing scenario. |
bit-byte0
force-pushed
the
fix/datagrid-drag-icon-sticky-columns
branch
from
July 15, 2026 15:58
99b09e2 to
1ba4ddb
Compare
bit-byte0
force-pushed
the
fix/datagrid-drag-icon-sticky-columns
branch
from
July 16, 2026 10:08
c1bf630 to
1ba4ddb
Compare
bit-byte0
force-pushed
the
fix/datagrid-drag-icon-sticky-columns
branch
from
July 16, 2026 10:52
c1bf630 to
3439d89
Compare
anna-shakhova
previously approved these changes
Jul 16, 2026
bit-byte0
force-pushed
the
fix/datagrid-drag-icon-sticky-columns
branch
from
July 16, 2026 17:26
50471ce to
0ae7946
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes vertical alignment of the row drag icon in DataGrid and TreeList with enabled column fixing: the icon is now centered and no longer shifts when a row is focused or selected.
Also fixes a related pre-existing defect in the fluent theme: a focused or selected row (without row lines) shrank by 1px, making the whole row and its content jump.
How
.dx-command-dragcells from the sticky-columns padding compensation rules in the generic, material, and fluent themes (the same pattern as the existing.dx-editor-cellexclusion)padding-topcompensation on focused rows: unlike generic/material (border on both sides of the highlighted row), fluent draws only a 1px bottom border, so dropping 2px of padding shrank the rowpadding-topto the drag cell in focused rows to mirror that bottom border - otherwise the middle-aligned icon rises half a pixel because the cell's content box shrinks from one side only