Grids: fix unstable editing tests#34293
Open
anna-shakhova wants to merge 1 commit into
Open
Conversation
anna-shakhova
force-pushed
the
ubstable_tests_editing_26_2
branch
5 times, most recently
from
July 16, 2026 14:16
ed67ead to
da0bc55
Compare
anna-shakhova
changed the title
anna-shakhova
marked this pull request as ready for review
July 16, 2026 14:17
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to stabilize DataGrid editing-related TestCafe E2E tests by adding stronger synchronization points (readiness / editor existence / focus checks) and making async validation deterministic to reduce timing-related flakes.
Changes:
- Added explicit assertions that editors exist and are focused before interacting (keyboard navigation + sticky editing scenarios).
- Reworked one async validation test to use a controllable
$.Deferred()resolved from the test instead ofsetTimeout. - Removed
unstablemeta markers from some tests after adding extra synchronization.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| e2e/testcafe-devextreme/tests/dataGrid/sticky/common/withEditing.ts | Adds edit-cell + editor-focus assertions (and fixes a typo) to reduce flakiness in sticky columns editing. |
| e2e/testcafe-devextreme/tests/dataGrid/common/keyboardNavigation/keyboardNavigation.functional.ts | Adds editor existence checks before focus assertions; removes an unstable meta marker for a tab-navigation scenario. |
| e2e/testcafe-devextreme/tests/dataGrid/common/editing/functional.ts | Makes async validation deterministic via a shared deferred resolved by the test (but currently leaves a global behind under disablePageReloads). |
| e2e/testcafe-devextreme/tests/dataGrid/common/editing/editing.functional_matrix.ts | Adds editor existence checks and dataGrid.isReady() waits; removes an unstable meta marker for a focus-next-cell scenario. |
anna-shakhova
force-pushed
the
ubstable_tests_editing_26_2
branch
from
July 16, 2026 14:29
da0bc55 to
052b3ab
Compare
Tucchhaa
reviewed
Jul 17, 2026
Comment on lines
+170
to
173
| .expect(editor?.element.exists) | ||
| .ok() | ||
| .expect(editor?.element.focused) | ||
| .eql(true); |
Contributor
There was a problem hiding this comment.
Afaik .expect(editor?.element.focused) will already make testcafe to wait for the element to appear and be focused.
Are you sure that expect(editor?.element.exists) fixes instability?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.