Scheduler - Remove old render#33768
Open
aleksei-semikozov wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes Scheduler’s legacy (“old”) workspace rendering path and the renovateRender option, updating internal workspace logic and test suites to rely on renovated rendering APIs (e.g., getCellData) exclusively.
Changes:
- Removed
renovateRenderoption plumbing and old-render branches from Scheduler/workspace internals. - Refactored workspace/timezone/timeline-related tests to stop toggling
renovateRenderand to validate cell data viagetCellData(...). - Simplified/merged duplicated test cases that previously ran in both renovated and old render modes.
Reviewed changes
Copilot reviewed 31 out of 31 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/workSpace.week.tests.js | Stops using renovateRender/jQuery data; validates via getCellData. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/workSpace.renovation.tests.js | Removes explicit renovateRender: true setup. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/workSpace.navigation.tests.js | Removes renovateRender: true from navigation setups. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/workSpace.month.tests.js | Collapses dual-mode tests; switches to getCellData. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/workSpace.markup-1.tests.js | Updates markup assertions to use getCellData; removes old-render branching. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/workSpace.day.tests.js | Removes old-render toggles; uses getCellData and keeps immutability check. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/views.renovation.tests.js | Removes renovateRender: true from renovated view tests. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/views.cellTemplate.tests.js | Removes dual-mode loops; makes templates tests single-path. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/timezones.tests.js | Removes renovateRender loops from timezone drag/render regression tests. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/timeline.tests.js | Removes renovateRender branching in timeline scrolling tests. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/timeline.markup.tests.js | Replaces dxCellData element-data reads with getCellData. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/subscribes.tests.js | Removes renovateRender loops for grouping-by-date behavior tests. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/pacificTime.tests.js | Removes renovateRender parameterization from DST template-args tests. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/integration.workSpace.tests.js | Uses workspace getCellData in integration assertions; removes old-render conditionals. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/integration.resources.tests.js | Removes renovateRender loop from resources dataSource update test. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/integration.multiWeekAppointments.tests.js | Removes renovateRender loop from RTL multi-week appointments test. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/common.tests.js | Removes renovateRender loop from grouped scroll-height test. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/appointment.week.based.views.tests.js | Unifies cell-data retrieval to renovated workspace API. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/appointment.timeLines.tests.js | Removes renovateRender parameterization for a timeline regression test. |
| packages/devextreme/testing/tests/DevExpress.serverSide/scheduler.tests.js | Removes server-side test that asserted renovateRender behavior. |
| packages/devextreme/js/__internal/scheduler/workspaces/view_model/m_view_data_generator.ts | Cleans up old-render-related TODO comment. |
| packages/devextreme/js/__internal/scheduler/workspaces/m_work_space.ts | Deletes old-render branches, removes isRenovatedRender, always uses renovated rendering path. |
| packages/devextreme/js/__internal/scheduler/workspaces/m_work_space_month.ts | Removes old-render-only overrides/custom table-body rendering. |
| packages/devextreme/js/__internal/scheduler/workspaces/m_work_space_indicator.ts | Always rerenders renovated header/time panel for current-time indication updates. |
| packages/devextreme/js/__internal/scheduler/workspaces/m_work_space_day.ts | Removes old-render date-header override. |
| packages/devextreme/js/__internal/scheduler/workspaces/m_timeline.ts | Removes old-render week header/group header template application; always updates virtual scrolling dimensions. |
| packages/devextreme/js/__internal/scheduler/workspaces/m_agenda.ts | Adjusts method declarations after base old-render methods removal; disables virtual scrolling explicitly. |
| packages/devextreme/js/__internal/scheduler/workspaces/helpers/m_position_helper.ts | Cleans up old-render-related TODO comment. |
| packages/devextreme/js/__internal/scheduler/utils/options/types.ts | Removes renovateRender from internal options type. |
| packages/devextreme/js/__internal/scheduler/utils/options/constants.ts | Removes default internal renovateRender option value. |
| packages/devextreme/js/__internal/scheduler/m_scheduler.ts | Removes renovateRender propagation logic and SSR-related toggle helper. |
Comment on lines
2369
to
2373
| this.initGroupedStrategy(); | ||
| this.createAllDayPanelElements(); | ||
| this.createRAllDayPanelElements(); | ||
| this.removeAllDayElements(); | ||
| this.cleanWorkSpace(); | ||
| this.toggleGroupByDateClass(); |
| assert.strictEqual(scheduler.appointments.getAppointmentCount(), 4, 'Appointments are rendered'); | ||
| assert.strictEqual($(scheduler.appointments.getAppointment(2)).position().left, $(scheduler.appointments.getAppointment(3)).position().left, 'Appointments have same left coordinate'); | ||
| assert.strictEqual($(scheduler.appointments.getAppointment(2)).innerWidth(), $(scheduler.appointments.getAppointment(3)).innerWidth(), 'Appointments with equal coords have same width'); | ||
| assert.strictEqual($(scheduler.appointments.getAppointment(3)).innerWidth(), $(scheduler.appointments.getAppointment(3)).innerWidth(), 'Appointments with defferent coords have same width'); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.