Fix audit alerts and enforce frozen lockfile#33266
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens dependency reproducibility and reduces CI variability by enforcing --frozen-lockfile across GitHub workflows, and updates the build tooling that fetches external documentation content used during package builds.
Changes:
- Enforce
pnpm install --frozen-lockfileacross CI workflows to prevent lockfile drift during installs. - Update
tools/scripts/build-all.tsto install and run documentation tooling viapnpmand adjust the temporary documentation clone directory. - Remove outdated/commented Angular polyfill install hints and remove an unused composite GitHub Action for Chrome headless shell setup.
Reviewed changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tools/scripts/build-all.ts | Switch doc repo install/run steps to pnpm and change documentation temp clone location. |
| apps/angular/src/polyfills.ts | Remove outdated inline “npm install” hints from commented polyfill imports. |
| .github/workflows/wrapper_tests_e2e.yml | Use frozen lockfile for deterministic installs. |
| .github/workflows/wrapper_tests.yml | Use frozen lockfile for deterministic installs. |
| .github/workflows/update_version.yml | Use frozen lockfile for deterministic installs. |
| .github/workflows/ts_declarations.yml | Use frozen lockfile for deterministic installs. |
| .github/workflows/themebuilder_tests.yml | Use frozen lockfile for deterministic installs. |
| .github/workflows/testcafe_tests.yml | Use frozen lockfile for deterministic installs. |
| .github/workflows/styles.yml | Use frozen lockfile for deterministic installs. |
| .github/workflows/run-testcafe-on-gh-pages.yml | Use frozen lockfile for deterministic installs. |
| .github/workflows/renovation.yml | Use frozen lockfile for deterministic installs. |
| .github/workflows/qunit_tests.yml | Use frozen lockfile for deterministic installs. |
| .github/workflows/publish-demos.yml | Use frozen lockfile for deterministic installs. |
| .github/workflows/playgrounds_tests.yml | Use frozen lockfile for deterministic installs. |
| .github/workflows/packages_publishing.yml | Use frozen lockfile for deterministic installs. |
| .github/workflows/lint.yml | Use frozen lockfile for deterministic installs; remove separate lockfile-update/check job and adjust notification dependencies. |
| .github/workflows/demos_visual_tests.yml | Use frozen lockfile for deterministic installs; remove commented-out wrapper build/link steps. |
| .github/workflows/demos_unit_tests.yml | Use frozen lockfile for deterministic installs. |
| .github/workflows/default_workflow.yml | Use frozen lockfile for deterministic installs. |
| .github/workflows/codeql.yml | Use frozen lockfile for deterministic installs. |
| .github/workflows/build_all.yml | Use frozen lockfile for deterministic installs. |
| .github/actions/setup-chrome-headless-shell/action.yml | Remove unused composite action. |
| .github/actions/run-qunit-tests/action.yml | Remove commented-out Chrome setup section referencing removed action. |
Comments suppressed due to low confidence (1)
tools/scripts/build-all.ts:28
- DOCUMENTATION_TEMP_DIR is now created in the parent of ROOT_DIR ("../doc_tmp") and later deleted via
rm -rf. This can delete data outside the repo/workspace (e.g., if a siblingdoc_tmpalready exists) and can also cause collisions between concurrent runs. Prefer creating the temp clone directory underARTIFACTS_DIR(as before) or via an OS temp directory (e.g.,fs.mkdtempunderos.tmpdir()), ideally with a unique suffix, and only deleting within that scoped location.
const DOCUMENTATION_TEMP_DIR = path.join(ARTIFACTS_DIR, 'doc_tmp');
sh.exec(`git clone -b ${MAJOR_VERSION} --depth 1 --config core.longpaths=true https://github.com/DevExpress/devextreme-documentation.git ${DOCUMENTATION_TEMP_DIR}`);
sh.pushd(DOCUMENTATION_TEMP_DIR);
sh.exec('npm ci');
sh.exec(`npm run update-topics -- --artifacts ${INTERNAL_TOOLS_ARTIFACTS}`);
sh.popd();
sh.rm('-rf', DOCUMENTATION_TEMP_DIR);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.