fix(MediaQuality): don't skip HEIC/HEIF transcode#732
Open
Alpha3288 wants to merge 1 commit into
Open
Conversation
The image-quality overrides added in 72624df enable ab-prop 26291, which turns on WhatsApp's Jarvis ML image-transcode config (UitTranscodeConfig / JarvisImageConfig) in ProcessImageTaskConnector. That path's native passthrough decision mishandles HEIC/HEIF: the source is uploaded without being transcoded to JPEG, so recipients get "something wrong with the image file". On-device bisection confirmed 26291 as the sole culprit (26289 is the same gate for a different image mode and is unaffected), so drop only that flag and keep the maxKb/quality/maxEdge quality knobs and the other props. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Sending a HEIC/HEIF image with HD Quality Images enabled produces a corrupt upload - the recipient sees "This image is not available because something is wrong with the image file." Reproduced on WhatsApp 2.26.26.x.
Root cause
feat(MediaQuality): add configuration for improved media quality settings(72624df) sets five image-path A/B-prop booleans. One of them, 26291, enables WhatsApp's Jarvis ML image-transcode config (UitTranscodeConfig/JarvisImageConfig) inProcessImageTaskConnector:That path's native passthrough decision mishandles HEIC/HEIF: the source is uploaded without being transcoded to JPEG, so recipients can't decode it.
How it was diagnosed
26289+26291-> broken;26289only -> OK;26291only -> broken; all-except-26291-> OK.C00D.A0s(int)), then recovered theProcessImageTaskConnectorcoroutine that reads it.26289is the same gate for a different image mode (unaffected);6033/9569/22375are inert or unrelated.Fix
Drop only
26291, keeping themaxKb/quality/maxEdgequality knobs and the other props - the HD-image quality boost is preserved while HEIC/HEIF transcodes to JPEG correctly again.Verified on-device: with the fix and HD Images enabled, HEIC images send and open correctly for the recipient.