Skip to content

feat: add support for MCP ping#354

Merged
DeusData merged 1 commit into
DeusData:mainfrom
cmeerw:support-ping-mcp-request
May 30, 2026
Merged

feat: add support for MCP ping#354
DeusData merged 1 commit into
DeusData:mainfrom
cmeerw:support-ping-mcp-request

Conversation

@cmeerw
Copy link
Copy Markdown
Contributor

@cmeerw cmeerw commented May 14, 2026

Fixes #353

@DeusData
Copy link
Copy Markdown
Owner

Thank you, @cmeerw! 🙏 This directly fixes #353 — clients like crush send a ping and fork a second server process if they don't get a success response, so a correct empty-result reply matters. Returning {} is exactly the MCP-spec response for ping, and heap_strdup keeps the ownership consistent with the other result_json branches. Verified locally: build clean, all 3,617 tests pass. Merging via squash — authorship preserved. Closes #353. Thanks for making the MCP surface more spec-compliant!

@DeusData DeusData merged commit 9d6e28b into DeusData:main May 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Need to support "ping" requests

2 participants