fix: pick up GraphCompose 1.9.1 (inline-code column overflow)#47
Merged
Conversation
Long inline-code with no spaces — package coordinates, FQCNs, URLs — overflowed its table cell or paragraph on the 1.9.0 engine, drawing over the neighbouring column or off the right page margin (graph-compose-markdown renders inline code through RichText.highlight, the exact path the engine fix repairs). Bump graphcompose.version 1.9.0 -> 1.9.1 so develop (and the eventual 0.4.0) carries the fix; the 0.3.x line ships it as 0.3.1. No source or public API change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Long inline-code with no spaces — package coordinates, FQCNs, URLs like
org.junit.jupiter:junit-jupiter:5.10.2— overflowed its table cell or paragraph on theGraphCompose 1.9.0 engine, drawing straight over the neighbouring column (or off the
right page margin). This library renders inline code through
InlineRenderer→RichText.highlight(...)— the exact highlight-chip path the engine fix repairs.Reproduced on the real released 1.9.0 (the copy in a clean local repo, not the
locally-rebuilt one): the
Codecolumn's content drew over theNotecolumn and theparagraph token ran off the page margin. On 1.9.1 it wraps within its column.
What changed
graphcompose.version1.9.0 → 1.9.1. The engine now breaks over-wide inline-codewithin its column (at
.:/-seams, char-splitting only as a last resort, chipfill preserved on every fragment) and grows
auto()table columns to fit composed cellcontent.
[Unreleased]Build note.No source or public API change here. The 0.3.x line ships the same fix as the 0.3.1
patch; this PR keeps
develop(and the eventual 0.4.0) from regressing to the old engine.Verification
./mvnw test -pl .→ 188 tests, 0 failures (1 skipped) on 1.9.1.