docs(templates): redraw the cv.v2 layer diagrams for the extracted core#255
Merged
Conversation
The cv.v2 package now owns four layers (data / components / widgets / presets); theme, the neutral header widgets, and the markdown/text helpers moved to templates.core.*. Update the docs that still drew the pre-extraction structure. - cv/v2/package-info + quickstart: redraw the ASCII layer diagrams as "four CV layers, built on the shared core"; correct the widget homes (header bricks in core.identity), preset count (16), and the theme / text attributions. - AUTHORS: correct the layer list. - DocumentTemplate: drop the v1.6 migration-window wording and the phantom CvTemplate; the factory theme type is per-family (BrandTheme for cv / cover-letter and the layered invoice / proposal presets). - themes/Spacing + Typography: reword the dangling historical BrandTheme.spacing / .defaultTheme() references.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
After the core extraction (#248–#252), the cv.v2 author docs still drew the pre-extraction structure — ASCII "layer" diagrams that put theme and the neutral header widgets inside cv.v2, a "5 layers" framing, a 9-preset list, and javadoc referencing a phantom
CvTemplateand acreate(BusinessTheme)factory that no longer matches the per-family theme types.What
templates.core.*"; header bricks (Headline,ContactLine, …) shown incore.identity, preset count corrected to 16, theme/text incore.theme/core.text. Boxes are width-padded so borders align.CvTemplate; thecreate(theme)factory's theme type is per-family —BrandThemefor the cv / cover-letter presets and the layered invoice / proposal presets.BrandTheme.spacing/.defaultTheme(){@code}references.Docs/javadoc only — no code or behaviour change.
Tests
./mvnw verify javadoc:javadoc -pl .→ BUILD SUCCESS, 1612 tests, 0 failures; javadoc report clean.