chore(templates): retire dead scaffolding, deprecate superseded public types for 2.0#247
Open
DemchaAV wants to merge 2 commits into
Open
chore(templates): retire dead scaffolding, deprecate superseded public types for 2.0#247DemchaAV wants to merge 2 commits into
DemchaAV wants to merge 2 commits into
Conversation
…c types for 2.0 Remove the empty tables/ placeholder package and the package-private BuiltInCvTemplateSupport (zero references); drop the dead Gen-2 sample methods from the examples ExampleDataFactory so examples no longer touch the deprecated cv.spec / coverletter.spec surface. Public types that are superseded but present in the v1.7.0 binary baseline — CoverLetterTemplate and the cv/v2 Headline/Contact/Banner renderers — are marked @deprecated(forRemoval) in 1.9.0 with rows in the 2.0 ledger instead of being removed. Rewrite the AUTHORS.md recipe and stale doc references onto the real widget APIs (Headline, ContactLine, SectionHeader).
DemchaAV
force-pushed
the
chore/templates-dead-code
branch
from
d935bbd to
a5416af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The template layer carries scaffolding that no longer earns its place: an empty
placeholder package, a package-private support class nothing reaches, dead Gen-2
sample data in the examples, and an authoring recipe that teaches superseded
renderers. Clearing it keeps the surface honest and binary-compatible.
What changed
Removed (internal, zero references):
templates/tables/— placeholder package that only ever heldpackage-info.java; no classes were built.templates/builtins/BuiltInCvTemplateSupport— package-private, no callers.sampleCvSpecV2/sampleCvHeaderV2/sampleCoverLetterSpecV2/sampleCoverLetterHeaderV2in the examplesExampleDataFactory(uncalled), plus their now-orphanedtemplates.blocks/cv.spec/coverletter.specimports — the examples module no longer depends on the deprecated Gen-2 spec surface.Deprecated for removal (public + present in the
v1.7.0binary baseline, so removed only at the next major):templates.api.CoverLetterTemplate— nothing implements it; cover-letter presets implement the genericDocumentTemplate<CoverLetterDocumentSpec>seam. Now@Deprecated(since = "1.9.0", forRemoval = true).cv.v2.components.HeadlineRenderer/ContactRenderer/BannerRenderer— already-deprecated pre-widgets shims, nowforRemoval; the live equivalents are thecv.v2.widgetsHeadline/ContactLine/SectionHeader.docs/api-stability.md2.0 ledger and theCHANGELOGDeprecations section.Docs: the
cv/v2/AUTHORS.md“write a new preset” recipe now calls the real widget APIs (Headline.spacedCentered,ContactLine.centered,SectionHeader.banner) instead of the deprecated renderers; theMinimalUnderlinedjavadoc link, theCvDecorationcomment,docs/architecture/package-map.md, and ADR-0011 are updated to match.Lane: templates (canonical) + docs. No engine changes. No behavioral change to any shipped template — the deletions are unreferenced and the deprecations keep compiling.
Verification
./mvnw -P japicmp verify -pl .→BUILD SUCCESS,Tests run: 1605, Failures: 0, Errors: 0, javadoc gate clean, binary-compatibility green against thev1.7.0baseline (no public type removed)../mvnw -f examples/pom.xml test-compile→ clean;GenerateAllExamplesregenerates every example PDF.