create fortify parser V2 - prefer true line#15228
Open
paulOsinski wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since line feeds hash-code deduplication, findings imported via FPR could never dedupe against the same findings from other parsers configured on File Path + Line Number. The XML report parser is unaffected — it already uses the issue's LineStart.
Fix
compute_line() now prefers SourceLocation's line attribute and falls back to the snippet start only when it's missing.
Tests
re: V2
many users are using the original parser, so v2 was created to avoid finding churn