security: fix HIGH SCA vulns in go-git/go-billy deps - #234
Open
sawez-deepsource wants to merge 1 commit into
Open
security: fix HIGH SCA vulns in go-git/go-billy deps#234sawez-deepsource wants to merge 1 commit into
sawez-deepsource wants to merge 1 commit into
Conversation
Bump github.com/go-git/go-git/v5 v5.14.0 -> v5.19.1, which transitively pulls go-billy/v5 to v5.9.0. Clears both HIGH advisories from the SCA scan: - CVE-2026-45022 / GO-2026-5074 (go-git) fixed in 5.19.0 - CVE-2026-44973 / GO-2026-5597 (go-billy) fixed in 5.9.0 Targets 5.19.1 (one patch above the scan's 5.19.0) as the minimal version clearing every known go-git 5.x advisory; it also sweeps the incidental MODERATE/LOW go-git, go-billy and cloudflare/circl advisories. go.sum regenerated via `go mod tidy`. go.mod/go.sum only, no code changes.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Clears both HIGH SCA advisories flagged for
globstarin the July scan by bumping thego-gitdependency family. Lock/manifest change only (go.mod+go.sum).A single direct bump of
go-git/v5does it —go-billyis its transitive filesystem dep, so go-git v5.19.1 (which pins go-billy v5.9.0) pulls the fixed go-billy automatically via MVS.Why v5.19.1 (not the scan's 5.19.0)
5.19.0 fixes the flagged HIGH (GO-2026-5074) but leaves 3 other known go-git advisories in the tree. v5.19.1 is the minimal version clearing every known go-git 5.x advisory (verified against OSV) — same minor, still in-major v5, no added risk. It also incidentally sweeps the MODERATE/LOW go-git, go-billy, and
cloudflare/circladvisories that govulncheck found present in the binary.Transitive changes (all consequences of the go-git bump)
All
// indirect, pulled by go-git v5.19.1's own requirements:ProtonMail/go-crypto1.1.5→1.1.6,cloudflare/circl1.6.0→1.6.3,cyphar/filepath-securejoin0.4.1→0.6.1,pjbgf/sha1cd0.3.2→0.6.0,+klauspost/cpuid/v22.3.0. Plustestify1.10.0→1.11.1 (test-only; go-git's test-dep floor via MVS).godirective unchanged (1.25.0).Why this is safe
go-gitis used in exactly one file —pkg/cli/git.go(GetChangedFiles) — via stable core APIs (PlainOpen,Worktree,Status,plumbing.NewHash,CommitObject,Tree.Diff,merkletrie). v5.14→v5.19 is entirely within major v5, so no breaking API changes; confirmed by byte-identical analysis output before vs after.Verification
make buildclean;make testall pass, coverage 27.6% identical baseline vs after (pkg/cli40.4% identical);make test-builtin-rules→ all builtin rule tests pass.golang.org/x/crypto/openpgpis unmaintained) — no fix version exists, it's module-level and not called, and it was present pre-change (no regression).check --new-since-rev=<full-hash>) resolves commits, computes the tree diff, and finds issues byte-identically — 35-file changeset → 3 issues, 7-file → 0 issues.Blast radius
go.mod/go.sumonly. 0 code changes. One direct bump (go-git); everything else is its transitive closure.