fix: validate MaxEntries to prevent infinite loop in DebugEntryStore#119
Merged
georgidhristov merged 1 commit intoJun 12, 2026
Merged
Conversation
Collaborator
|
Tested locally with The application now fails fast during startup with a clear validation error instead of hanging on the first request. Thanks for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #112
Problem
Setting MaxEntries to a negative value or zero causes an infinite loop
in DebugEntryStore.Add(), because the while condition is always true.
Solution
Added DebugProbeOptionsValidator that validates MaxEntries >= 1
during startup. If the value is invalid, an InvalidOperationException
is thrown immediately with a clear error message.
Testing