Mark registered pre-aggs EXTERNAL and guard against DJ materialization#2342
Draft
shangyian wants to merge 2 commits into
Draft
Mark registered pre-aggs EXTERNAL and guard against DJ materialization#2342shangyian wants to merge 2 commits into
shangyian wants to merge 2 commits into
Conversation
Adds an EXTERNAL MaterializationStrategy value and a nullable `name` column
to pre_aggregation (Alembic migration pa0002external), and has
/preaggs/register set strategy=EXTERNAL and the optional name on the
pre-aggs it creates.
Guards: /preaggs/{id}/materialize and /preaggs/{id}/backfill now reject
EXTERNAL pre-aggs — DJ must never overwrite or backfill a table built and
maintained by an external pipeline. EXTERNAL stays out of
VALID_PREAGG_STRATEGIES so /preaggs/plan keeps rejecting it too.
The `name` handle is exposed on PreAggregationInfo for YAML-deploy
reconciliation and availability-by-name callbacks (PR 4 part 2).
Advances DataJunction#2118.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
test_materialization_info asserts the full strategy list; the new EXTERNAL
strategy adds an {'label': 'External', 'name': 'external'} entry.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an
EXTERNALMaterializationStrategy value and a nullablenamecolumn topre_aggregation.With this change,
/preaggs/{id}/materializeand/preaggs/{id}/backfillnow rejectEXTERNALpre-aggs, since DJ should never overwrite or backfill a table built and maintained by an external pipeline.EXTERNALstays out ofVALID_PREAGG_STRATEGIESso/preaggs/plankeeps rejecting it too.Advances #2118.
Test Plan
make checkpassesmake testshows 100% unit test coverageDeployment Plan