Handle deletion of namespaces during dj push#2148
Merged
Merged
Conversation
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
dj push
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dj push ./nodes --namespace <ns>was supposed to sync the server-side namespace with the contents of the folder, but child namespaces were never pruned. If you deleted a sub-folder locally, the nodes inside it got removed but the empty namespace lingered on the server, breaking the "this folder is the source of truth" mental model during deployments.This PR adds server-side namespace pruning in the deployment orchestrator. During plan creation, we diff the existing child namespaces under the deployment root against the desired set (built from local nodes' rendered names). Anything in the diff gets removed after node deletion, deepest-first. These changes are dry-run aware, so that calls to
POST /deployments/impactalso surface upcoming namespace deletions in its results.This also adds a new result type:
DeploymentResult.Type.NAMESPACEso that namespace operations show up distinctly in the deployment report alongside node / link / tag.Test Plan
make checkpassesmake testshows 100% unit test coverageDeployment Plan