Auto-wrap ratio metric denominators in NULLIF#2147
Merged
Conversation
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
NULLIF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Division-by-zero in metric SQL surfaces inconsistently across engines (Spark returns NaN, Trino raises an error, Postgres returns Infinity). The fix is to auto-wrap the right-hand side of every divide in the metric's combiner expression with
NULLIF(denominator, 0), in two places:AVGA rate computed over zero observations is mathematically undefined; NULL represents that correctly and propagates safely through downstream aggregations. The auto-wrap normalizes divide-by-zero behavior across Spark/Trino/Postgres/Druid, and closes the class of "data unavailable" / NaN-percentile bugs without requiring every consumer to re-implement the same patch.
Test Plan
make checkpassesmake testshows 100% unit test coverageDeployment Plan