fix: resolve data race on IsOpen and channel-close race condition - #31
Open
belowzeroff wants to merge 1 commit into
Open
Conversation
- Add sync.Mutex for thread-safe IsOpen access across goroutines - closeConnection no longer closes rawReadChan (was causing panic when kdbHandleListener tried to send after channel close) - Dispose now owns rawReadChan lifecycle: closes it after signalling all goroutines to stop
belowzeroff
force-pushed
the
fix/concurrency-data-race-channel-panic
branch
from
July 23, 2026 10:53
72029c2 to
e980cbe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two concurrency bugs:
Data race on
IsOpen— multiple goroutines (syncQueryRunner,kdbHandleListener,Dispose) read/writeIsOpenwithout synchronization. Addedsync.Mutexwith accessor methodsgetOpen()/setOpen().Send on closed
rawReadChanpanic — when a query times out,syncQueryRunnercallsCloseConnection()which closesrawReadChan. MeanwhilekdbHandleListenermay still try to send to it, causing a panic. Fixed by:closeConnectionno longer closesrawReadChanDisposenow ownsrawReadChanlifecycle, closing it after signal 3 stops all goroutinesVerification
go build ./...succeedsgo vet ./...shows no new warnings