feat: add per-weblog metadata to control CI build requirement#7130
Open
rochdev wants to merge 10 commits into
Open
feat: add per-weblog metadata to control CI build requirement#7130rochdev wants to merge 10 commits into
rochdev wants to merge 10 commits into
Conversation
Contributor
|
|
|
Introduce {name}.weblog.json companion files alongside Dockerfiles.
When require_build is false, the weblog is excluded from
build_end_to_end's matrix, which already skips the job when the
list is empty. Set all Node.js regular weblogs to require_build=false.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
When require_build=False, artifact_name must use the pre-existing binaries_artifact instead of a unique per-run name, since build_end_to_end is skipped and never uploads that artifact. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
require_build controls parallel_weblogs (pre-build job). needs_local_build controls weblog_build_required in run_end_to_end. Non-Dockerfile weblogs (integration frameworks, go_proxies, otel_collector) set needs_local_build=False; Dockerfile-based weblogs default to True, so they still build locally even when require_build=False skips the pre-build job. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
require_build now consistently means 'needs Docker build' (True for all Dockerfile weblogs, False for non-Dockerfile). require_prebuild controls parallel_weblogs membership and _get_build_time. Metadata key renamed from require_build to require_prebuild accordingly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
rochdev
force-pushed
the
rochdev/weblog-build-metadata
branch
from
8d7e3e7 to
2cc3e61
Compare
Co-authored-by: Roch Devost <roch.devost@datadoghq.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
nccatoni
approved these changes
Jun 17, 2026
rochdev
requested review from
avara1986,
claponcet,
dougqh,
jandro996 and
rachelyangdog
and removed request for
a team
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dc55d067f4
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
nccatoni
force-pushed
the
rochdev/weblog-build-metadata
branch
from
f7d8c88 to
7d3047a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{name}.weblog.jsoncompanion files alongside weblog Dockerfiles; whenrequire_buildisfalse, the weblog is excluded from thebuild_end_to_endCI matrixexpress4,express4-typescript,express5,fastify,nextjs,uds-express4) torequire_build: false— they use pre-built base images and don't need a per-run buildbuild_end_to_endalready skips automatically whenparallel_weblogsis empty (existing workflow condition:endtoend_defs_parallel_weblogs != '[]'); no workflow file change neededTest Plan
test_nodejs_weblogs_dont_require_build— verifiesparallel_weblogsis empty fornodejsand jobs are still producedtest_get_endtoend_definitions— verifies Ruby weblogs are unaffected (no.weblog.jsonfiles → stillrequire_build=True)test_ipv6_is_not_supported_for_uds_weblogs— no regression on existing tests🤖 Generated with Claude Code