v0.17.0#178
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8df94ebfb7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| libdd-trace-stats = { git = "https://github.com/DataDog/libdatadog.git", tag = "v37.0.0", default-features = false } | ||
| libdd-trace-protobuf = { git = "https://github.com/DataDog/libdatadog.git", tag = "v37.0.0", default-features = false } | ||
| libdd-shared-runtime = { git = "https://github.com/DataDog/libdatadog.git", tag = "v37.0.0", default-features = false } | ||
| libdd-capabilities = { git = "https://github.com/DataDog/libdatadog.git", branch = "bengl/otlp-scope-v37" } |
There was a problem hiding this comment.
In the release wasm build path I checked, .github/actions/build-test-wasm/action.yaml runs wasm-pack build from a clean checkout; declaring this backport as a branch keeps the dependency mutable despite the current lockfile. If bengl/otlp-scope-v37 is force-pushed/deleted or the lockfile is regenerated, v0.17.0 can be rebuilt with different libdatadog code or fail to build, so use rev = "bc37255a7e74f94fd0801a76086df6b333850b8a" (or a tag) for these v37 backport deps.
Useful? React with 👍 / 👎.
Overall package sizeSelf size: 30.17 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------|🤖 This report was automatically generated by heaviest-objects-in-the-universe |
bengl
force-pushed
the
bengl/v0.17.0-proposal
branch
from
8df94eb to
c3276d6
Compare
* fix(pipeline): set OTLP instrumentation scope * fix(pipeline): consume ported libdatadog scope patch Update the temporary libdatadog dependency to the PR head ported onto main. Current libdatadog also changed the stats concentrator API, so adapt the WASM stats wrapper to pass the new cardinality limit argument and encode unobfuscated buckets from FlushResult. * fix(pipeline): return collapsed stats count from flushStats * test(pipeline): widen stats overflow regression
bengl
force-pushed
the
bengl/v0.17.0-proposal
branch
from
c3276d6 to
54a172b
Compare
2 participants
What does this PR do?
Release
@datadog/libdatadogv0.17.0 with the reviewed native-spans OTLP instrumentation scope work from #173.Changes:
d99947f) on thev0.xrelease branchInstrumentationScope.nametodd-trace-jsInstrumentationScope.versionfrom the tracer version8cd68ab922fb7aade0f089ccfc91291d874673afand its stats API adaptationpackage.jsonto0.17.0Motivation
Native OTLP export was sending an empty instrumentation scope. The dd-trace-js OTLP/system-tests path expects the same scope metadata as the JS pipeline.
This release PR now carries the reviewed #173 mainline change instead of the earlier v0.x-only backport.
How to test the change?
Ran in
/Users/bryan.english/worktrees/libdatadog-nodejs-v0170after including #173:cargo check -p pipeline --target wasm32-unknown-unknown/Users/bryan.english/.nvm/versions/node/v26.5.0/bin/node scripts/build-wasm.js pipeline/Users/bryan.english/.nvm/versions/node/v26.5.0/bin/node --test-force-exit test/pipeline.js— 51 passed/opt/homebrew/bin/yarn -s lint