Skip to content

Sy/external secrets pr3056 monitor fix - #3079

Draft
steveny91 wants to merge 8 commits into
masterfrom
sy/external-secrets-pr3056-monitor-fix
Draft

Sy/external secrets pr3056 monitor fix#3079
steveny91 wants to merge 8 commits into
masterfrom
sy/external-secrets-pr3056-monitor-fix

Conversation

@steveny91

Copy link
Copy Markdown
Contributor

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo
  • If this PR includes a log pipeline, please add a description describing the remappers and processors.

Additional Notes

Anything else we should know when reviewing?

@steveny91 steveny91 added the assets/no-deploy Prevents APW from deploying this PR in staging label Jul 29, 2026
@datadog-datadog-prod-us1

Copy link
Copy Markdown

🎯 Code Coverage (details)
Patch Coverage: 94.32%
Overall Coverage: 94.32% (+9.39%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: c4cf8c6 | Docs | Datadog PR Page | Give us feedback!

@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Monitor Template Quality Assessment

This check validates the notification message quality of monitor templates changed in this PR. Each monitor template message is evaluated against the recommended sections (What's Happening, Impact, Why, How to Troubleshoot, Related Links) as described in the Datadog monitor notification guidelines.

4 monitors analyzed across 1 integrations.

  • 4 monitors have missing sections
  • Most common missing sections: WHATS_HAPPENING, IMPACT, WHY
Monitors with missing sections
Integration Monitor File Owner Missing Sections
external-secrets [External Secrets] {{name.name}} not ready in {{namespace.name}} external_secrets/assets/monitors/external_secrets_not_ready.json agent-integrations WHATS_HAPPENING, IMPACT, WHY, HOW_TO_TROUBLESHOOT, RELATED_LINKS
external-secrets [External Secrets] Provider API Errors for {{provider.name}} ({{call.name}}) external_secrets/assets/monitors/provider_api_errors.json agent-integrations WHATS_HAPPENING, IMPACT, WHY, HOW_TO_TROUBLESHOOT, RELATED_LINKS
external-secrets [External Secrets] Sync Errors for {{name.name}} in {{namespace.name}} external_secrets/assets/monitors/sync_errors.json agent-integrations WHATS_HAPPENING, IMPACT, WHY, HOW_TO_TROUBLESHOOT, RELATED_LINKS
external-secrets [External Secrets] High Workqueue Depth for {{name.name}} external_secrets/assets/monitors/workqueue_depth.json agent-integrations WHATS_HAPPENING, IMPACT, WHY, HOW_TO_TROUBLESHOOT, RELATED_LINKS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

assets/no-deploy Prevents APW from deploying this PR in staging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant