Emit untagged telemetry when OpenMetrics reaches its metric limit#24588
Draft
nubtron wants to merge 2 commits into
Draft
Emit untagged telemetry when OpenMetrics reaches its metric limit#24588nubtron wants to merge 2 commits into
nubtron wants to merge 2 commits into
Conversation
Contributor
Validation ReportAll 21 validations passed. Show details
|
🎉 All green!🧪 All tests passed 🔄 Datadog auto-retried 1 job - 1 passed on retry 🎯 Code Coverage (details) 🔗 Commit SHA: 2231954 | Docs | Datadog PR Page | Give us feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Emits the untagged
openmetrics.max_returned_metrics_reachedAgent telemetry counter once per OpenMetrics check run when the existing metric limiter reachesmax_returned_metrics.The producer checks the limiter's structured
reached_limitstate before reset, then uses the existing four-argumentdatadog_agent.emit_agent_telemetryAPI. OpenMetrics v1 and v2 opt in; genericAgentChecklimiters do not. Emission is best-effort and cannot alter warning, drop, or reset behavior.The metric intentionally carries no tags, including no
check_name.Motivation
AI-7012 asks for a fleet-wide COAT signal for silent OpenMetrics drops after
max_returned_metricsis reached. An untagged first version provides that signal while avoiding warning-text parsing, new rtloader callbacks, and a generic labeled telemetry bridge.Validation included focused metric-limiter tests covering v1/v2 opt-in, once-per-run emission, generic-check exclusion, old-Agent compatibility, bridge failure behavior, and debug metric contexts. The complete
datadog_checks_baseformat/lint target also passed.Review checklist (to be filled by reviewers)
qa/requiredif this PR needs QA validation, orqa/skip-qaif it does not. Exactly one of the two is required.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged