Skip to content

[Backport 7.82.x] Rename mem_pool_index tag to mem in cisco-firepower-asa profile#24586

Open
dd-octo-sts[bot] wants to merge 2 commits into
7.82.xfrom
backport-24582-to-7.82.x
Open

[Backport 7.82.x] Rename mem_pool_index tag to mem in cisco-firepower-asa profile#24586
dd-octo-sts[bot] wants to merge 2 commits into
7.82.xfrom
backport-24582-to-7.82.x

Conversation

@dd-octo-sts

@dd-octo-sts dd-octo-sts Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Backport 9d36bc6 from #24582.


What does this PR do?

Renames the mem_pool_index metric tag to mem in the cisco-firepower-asa SNMP profile's memory metrics (CISCO-ENHANCED-MEMPOOL-MIB).

Motivation

This tag name is inconsistent with other profiles using the same CISCO-ENHANCED-MEMPOOL-MIB/cempMemPoolTable, such as cisco-nexus, which tags the same index as mem. This PR aligns cisco-firepower-asa with that convention.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add qa/required if this PR needs QA validation, or qa/skip-qa if it does not. Exactly one of the two is required.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Aligns with other profiles (e.g. cisco-nexus) that tag CISCO-ENHANCED-MEMPOOL-MIB memory metrics with mem instead of mem_pool_index.

(cherry picked from commit 9d36bc6)
@datadog-prod-us1-4

datadog-prod-us1-4 Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Tests  Code Coverage

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 93.93%

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 9ba310a | Docs | Datadog PR Page | Give us feedback!

@nubtron nubtron added the qa/required QA is required for this PR and will generate a QA card label Jul 17, 2026
@dd-octo-sts

dd-octo-sts Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

Validation Report

All 21 validations passed.

Show details
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file
ci Validate CI configuration and code coverage settings
codeowners Validate every integration has a CODEOWNERS entry
config Validate default configuration files against spec.yaml
dep Verify dependency pins are consistent and Agent-compatible
http Validate integrations use the HTTP wrapper correctly
imports Validate check imports do not use deprecated modules
integration-style Validate check code style conventions
jmx-metrics Validate JMX metrics definition files and config
labeler Validate PR labeler config matches integration directories
legacy-signature Validate no integration uses the legacy Agent check signature
license-headers Validate Python files have proper license headers
licenses Validate third-party license attribution list
metadata Validate metadata.csv metric definitions
models Validate configuration data models match spec.yaml
openmetrics Validate OpenMetrics integrations disable the metric limit
package Validate Python package metadata and naming
qa-label Validate the pull request declares whether it needs QA for the next Agent release
readmes Validate README files have required sections
saved-views Validate saved view JSON file structure and fields
version Validate version consistency between package and changelog

View full run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants