Implement normalised http routes

[estringana]

Description

Reviewer checklist

• Test coverage seems ok.
• Appropriate labels assigned.

[github-actions]

Snapshots difference summary

The following differences have been observed in committed snapshots. It is meant to help the reviewer.
The diff is simplistic, so please check some files anyway while we improve it.

If you need to update snapshots, please refer to CONTRIBUTING.md

[datadog-datadog-prod-us1-2]

 

✨ Unblock PR with BitsAI

⚠️ Warnings

🚦 235 Pipeline jobs failed

DataDog/apm-reliability/dd-trace-php | test_web_cakephp_28: [7.0]     

🧪 4 Tests failed

testScenario with data set "A GET request to a route with a parameter" from cakephp-28-test.DDTrace\Tests\Integrations\CakePHP\V2_8\CommonScenariosTest.DDTrace\Tests\Integrations\CakePHP\V2_8\CommonScenariosTest::testScenario  

DDTrace\Tests\Integrations\CakePHP\V2_8\CommonScenariosTest::testScenario with data set "A GET request to a route with a parameter" (DDTrace\Tests\Frameworks\Util\Request\GetSpec Object (...), array(DDTrace\Tests\Common\SpanAssertion Object (...)))
Got error from webserver:

tests/Common/WebFrameworkTestCase.php:74
tests/Common/MultiPHPUnitVersionAdapter_untyped.php:33
tests/Common/RetryTraitVersionSpecific70.php:28
phpvfscomposer://tests/vendor/phpunit/phpunit/phpunit:52

testScenario with data set "A GET request with an exception" from cakephp-28-test.DDTrace\Tests\Integrations\CakePHP\V2_8\CommonScenariosTest.DDTrace\Tests\Integrations\CakePHP\V2_8\CommonScenariosTest::testScenario  

DDTrace\Tests\Integrations\CakePHP\V2_8\CommonScenariosTest::testScenario with data set "A GET request with an exception" (DDTrace\Tests\Frameworks\Util\Request\GetSpec Object (...), array(DDTrace\Tests\Common\SpanAssertion Object (...)))
Got error from webserver:

tests/Common/WebFrameworkTestCase.php:74
tests/Common/MultiPHPUnitVersionAdapter_untyped.php:33
tests/Common/RetryTraitVersionSpecific70.php:28
phpvfscomposer://tests/vendor/phpunit/phpunit/phpunit:52

View all failed tests

DataDog/apm-reliability/dd-trace-php | test_web_cakephp_310: [7.2, apache2handler]     

🧪 4 Tests failed

testScenario with data set "A GET request to a route with a parameter" from cakephp-310-test.DDTrace\Tests\Integrations\CakePHP\V3_10\CommonScenariosTest.DDTrace\Tests\Integrations\CakePHP\V3_10\CommonScenariosTest::testScenario  

DDTrace\Tests\Integrations\CakePHP\V3_10\CommonScenariosTest::testScenario with data set "A GET request to a route with a parameter" (DDTrace\Tests\Frameworks\Util\Request\GetSpec Object (...), array(DDTrace\Tests\Common\SpanAssertion Object (...)))
cakephp.request: Unexpected extra values for 'tags':
Array
(
    [_dd.appsec.normalized_route] => /parameterized/{param}
)

Failed asserting that an array is empty.
Received Spans graph:
cakephp.request (service: cakephp_test_app, resource: GET ParameterizedController@customAction, type: web)
...

testScenario with data set "A GET request with an exception" from cakephp-310-test.DDTrace\Tests\Integrations\CakePHP\V3_10\CommonScenariosTest.DDTrace\Tests\Integrations\CakePHP\V3_10\CommonScenariosTest::testScenario  

DDTrace\Tests\Integrations\CakePHP\V3_10\CommonScenariosTest::testScenario with data set "A GET request with an exception" (DDTrace\Tests\Frameworks\Util\Request\GetSpec Object (...), array(DDTrace\Tests\Common\SpanAssertion Object (...)))
cakephp.request: Unexpected extra values for 'tags':
Array
(
    [_dd.appsec.normalized_route] => /{controller}
)

Failed asserting that an array is empty.
Received Spans graph:
cakephp.request (service: cakephp_test_app, resource: GET ErrorController@index, type: web)
...

View all failed tests

DataDog/apm-reliability/dd-trace-php | test_web_laminas_rest_latest: [8.1, apache2handler]     

🧪 3 Tests failed

testScenarioRest2xx from tests/Integrations/Laminas/ApiTools/Latest.DDTrace\Tests\Integrations\Laminas\ApiTools\Latest\RESTTest  

DDTrace\Tests\Integrations\Laminas\ApiTools\Latest\RESTTest::testScenarioRest2xx
Unexpected test failure during snapshot test: At request <Request GET /test/session/snapshot >:
   At snapshot (token='tests.integrations.laminas.api_tools.latest.rest_test.test_scenario_rest2xx'):
    - Directory: tests/snapshots
    - CI mode: 1
    - Trace File: tests/snapshots/tests.integrations.laminas.api_tools.latest.rest_test.test_scenario_rest2xx.json
    - Stats File: tests/snapshots/tests.integrations.laminas.api_tools.latest.rest_test.test_scenario_rest2xx_tracestats.json
    At compare of 1 expected trace(s) to 1 received trace(s):
     At trace 'laminas.request' (49 spans):
      At snapshot compare of span 'laminas.request' at position 1 in trace:
...

testScenarioRest4xx from tests/Integrations/Laminas/ApiTools/Latest.DDTrace\Tests\Integrations\Laminas\ApiTools\Latest\RESTTest  

DDTrace\Tests\Integrations\Laminas\ApiTools\Latest\RESTTest::testScenarioRest4xx
Unexpected test failure during snapshot test: At request <Request GET /test/session/snapshot >:
   At snapshot (token='tests.integrations.laminas.api_tools.latest.rest_test.test_scenario_rest4xx'):
    - Directory: tests/snapshots
    - CI mode: 1
    - Trace File: tests/snapshots/tests.integrations.laminas.api_tools.latest.rest_test.test_scenario_rest4xx.json
    - Stats File: tests/snapshots/tests.integrations.laminas.api_tools.latest.rest_test.test_scenario_rest4xx_tracestats.json
    At compare of 1 expected trace(s) to 1 received trace(s):
     At trace 'laminas.request' (33 spans):
      At snapshot compare of span 'laminas.request' at position 1 in trace:
...

View all failed tests

View all 235 failed jobs.

❄️ 49 New flaky tests detected

testCakePHPCatchAll from unit.DDTrace\Tests\Unit\Util\Normalizer\RouteNormalizerTest  

DDTrace\Tests\Unit\Util\Normalizer\RouteNormalizerTest::testCakePHPCatchAll
Exception: add DDTrace\Util\RouteNormalizer to bridge/_files.php or bridge/dd_register_optional_deps_autoloader.php

tests/bootstrap_common.php:47
tests/Unit/Util/Normalizer/RouteNormalizerTest.php:213
phpvfscomposer://tests/vendor/phpunit/phpunit/phpunit:52

New test introduced in this PR is flaky.

testCakePHPMixedSegment from unit.DDTrace\Tests\Unit\Util\Normalizer\RouteNormalizerTest  

DDTrace\Tests\Unit\Util\Normalizer\RouteNormalizerTest::testCakePHPMixedSegment
Exception: add DDTrace\Util\RouteNormalizer to bridge/_files.php or bridge/dd_register_optional_deps_autoloader.php

tests/bootstrap_common.php:47
tests/Unit/Util/Normalizer/RouteNormalizerTest.php:207
phpvfscomposer://tests/vendor/phpunit/phpunit/phpunit:52

New test introduced in this PR is flaky.

View in Flaky Test Management

ℹ️ Info

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 59.62% (-1.04%)

Useful? React with 👍 / 👎

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: dcf98a4 | Docs | Datadog PR Page | Give us feedback!}