build(deps): bump tests/FeatureFlags/ffe-system-test-data from 4446371 to c017a15 - #4098
Conversation
Bumps [tests/FeatureFlags/ffe-system-test-data](https://github.com/DataDog/ffe-system-test-data) from `4446371` to `c017a15`. - [Commits](DataDog/ffe-system-test-data@4446371...c017a15) --- updated-dependencies: - dependency-name: tests/FeatureFlags/ffe-system-test-data dependency-version: c017a15e1a153c27f325486df771a08e2a344022 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
dependabot
Bot
added
dependencies
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ad130e681c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| @@ -1 +1 @@ | |||
| Subproject commit 4446371bc1ca52bd526356927ef42d380145b118 | |||
| Subproject commit c017a15e1a153c27f325486df771a08e2a344022 | |||
There was a problem hiding this comment.
When this submodule is advanced to c017a15, several canonical cases now change only result.reason and add result.errorCode expectations (for example missing flags now expect ERROR/FLAG_NOT_FOUND, and date fixtures expect DEFAULT while keeping the same value). The only PHP sweep of these fixtures, tests/ext/ffe/system_test_data_evaluate.phpt, still compares just $details->getValue() against result.value, so a runtime that continues returning the old reasons or omits the new error code will still pass this bumped test data. Please extend the fixture runner to check getReason() and getErrorCode() whenever those fields are present so this dependency bump actually validates the updated contract.
Useful? React with 👍 / 👎.
| @@ -1 +1 @@ | |||
| Subproject commit 4446371bc1ca52bd526356927ef42d380145b118 | |||
| Subproject commit c017a15e1a153c27f325486df771a08e2a344022 | |||
There was a problem hiding this comment.
The bumped fixture set adds malformed/unsupported per-flag configs whose expected result is the caller default with reason: DEFAULT, but this repo currently maps EvaluationError::FlagConfigurationInvalid to ERROR_CONFIG_PARSE/REASON_ERROR in components-rs/ffe.rs:241; ResultMapper then turns any non-zero bridge error into error details before default handling. Once consumers or the fixture sweep inspect metadata, PHP will report PARSE_ERROR/ERROR for these new invalid-flag isolation cases instead of the canonical default result, so this bump should be paired with a mapping change that keeps whole-config parse failures as errors while treating per-flag invalid configs as default evaluations.
Useful? React with 👍 / 👎.
|
Bumps tests/FeatureFlags/ffe-system-test-data from
4446371toc017a15.Commits
c017a15Merge pull request #20 from greghuels/greg.huels/semver-comparison-fixtures7f3112cRefine SEMVER comparison boundaries1d7c325Add SEMVER comparison operator fixturesf3da9aeMerge pull request #18 from DataDog/leo.romanovsky/revert-regex-shard-bound-f...44092cefix: limit rollback to regex fixtures9864c01fix: restore static temporal allocation reasonscb09e08revert: remove regex and shard-bound fixturesa596df7Merge pull request #17 from DataDog/leo.romanovsky/regex-shard-bound-fixturesce45493Add regex and shard-bound fixtures6c7f63bMerge pull request #16 from DataDog/leo.romanovsky/malformed-split-shards-fix...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)