[CIEXE-2016] Migrate GitLab CI jobs to pod-level resource variables#4008
Draft
henryvo117 wants to merge 1 commit into
Draft
[CIEXE-2016] Migrate GitLab CI jobs to pod-level resource variables#4008henryvo117 wants to merge 1 commit into
henryvo117 wants to merge 1 commit into
Conversation
Replace per-container Kubernetes CPU/memory variables with a single KUBERNETES_POD_* budget in the generated CI templates so helper setup and build work share one pod resource reservation. Co-authored-by: Cursor <cursoragent@cursor.com>
Author
|
/gitlab resync-code |
|
View all feedbacks in Devflow UI.
resync successful |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate generated GitLab CI templates from per-container Kubernetes CPU/memory variables to a single
KUBERNETES_POD_*budget. This lets helper setup and build work share one pod reservation instead of reserving separate build and helper footprints that do not run concurrently.Reference: DataDog/datadog-static-analyzer#924
Notable decisions
generate-package.php,generate-tracer.php,generate-appsec.php,generate-profiler.php) so every generated job uses pod-level variables consistently.Trade-offs
ci.gitlab-runner.enable-pod-level-resourcesstill needs to be updated separately before this takes effect in CI.Impact
For internal, reduces inflated Kubernetes runner resource requests for dd-trace-php CI jobs once the feature flag is enabled.
Test plan
generate-templatessucceeds on the branch pipelinespec.resourcesset and build/helper containers have empty container-level resource specsci.gitlab-runner.enable-pod-level-resourcestargeting for dd-trace-phpJira: https://datadoghq.atlassian.net/browse/CIEXE-2016
Made with Cursor