Update Gradle to 9.7.1 - #12323
Conversation
|
🎯 Code Coverage (details) 🔗 Commit SHA: 1f8a303 | Docs | View more details | Give us feedback! |
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
d3e6403 to
1f8a303
Compare
There was a problem hiding this comment.
More details
The wrapper URL and checksum match Gradle 9.7.1. The GitLab cache and smoke-test version pins also use 9.7.1.
🤖 Datadog Autotest · Commit 1f8a303 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
|
/code blockers |
|
View all feedbacks in Devflow UI.
Checking merge blockers for #12323...
Detected 1 merge blocker(s) to address: 🟠 Pending
|
What Does This Do
Motivation
Adopt the Gradle 9.7.1 patch release while keeping every Gradle version pin synchronized.
Gradle fixed the dependency traversal issue tracked in gradle/gradle#38057 behind the
ENHANCED_GRAPH_ORDERINGfeature preview. Enabling that preview globally is not safe for this build yet because several tests intentionally use fat JARs alongside newer modular dependencies.Additional Notes
Validation of the feature preview exposed deterministic classpath collisions outside SofaRPC. One representative failure was:
MockServer's no-dependencies fat JAR contains an older JUnit Platform class which shadowed JUnit Platform 1.14.1 under enhanced ordering. OpenAI latest-dependency tests independently loaded incompatible OkHttp classes for the same reason. The preview was therefore removed, while the existing SofaRPC-local Netty alignment remains in place. Adopting enhanced graph ordering should be handled separately with a repository-wide fat-JAR collision audit before Gradle 10 makes it the default.
The Gradle 9.7.1 wrapper JAR is unchanged from 9.7.0 and still matches Gradle's published wrapper JAR checksum. The binary distribution checksum was updated to the official 9.7.1 value.
Validation:
./gradlew help./gradlew spotlessCheck./gradlew :components:http:http-api:test :components:http:http-api:forkedTest --rerun-tasks./gradlew :dd-java-agent:instrumentation:openai-java:openai-java-3.0:latestDepTest -PtestJvm=17 --rerun-tasks(95 tests passed)./gradlew :dd-java-agent:instrumentation:sofarpc:sofarpc-5.0:test :dd-java-agent:instrumentation:sofarpc:sofarpc-5.0:forkedTest :dd-java-agent:instrumentation:sofarpc:sofarpc-5.0:latestDepTest -PtestJvm=17 --rerun-tasks(7 tests passed, including the forked gRPC regression test)Precedent: #12162
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]