fix sfn x-datadog-tags input - #12320
Conversation
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
3bb82d7 to
0620e0c
Compare
|
🎯 Code Coverage (details) 🔗 Commit SHA: e7f5aca | Docs | View more details | Give us feedback! |
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
There was a problem hiding this comment.
More details
The configured propagator writes the required sampling priority and string-valued propagation tags without a reportable regression.
🤖 Datadog Autotest · Commit e7f5aca · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
What Does This Do
Builds the
_datadogobject injected into the Step FunctionsStartExecutioninputusing the standard context propagator instead of hand-written JSON.
The payload now reflects the configured propagation styles, and
x-datadog-tagsisthe encoded
_dd.p.*string rather than a JSON object of the client span's tags.Motivation
x-datadog-tagsis defined as a string. Emitting it as an object caused the DatadogLambda extension's Step Functions deserializer to reject the whole
_datadogpayload,so trace context was dropped across the Step Functions boundary. The object also never
carried the propagated tags downstream consumers rely on (
_dd.p.tid,_dd.p.dm) —it exposed unrelated span tags instead — and sampling priority was not injected at all.
Additional Notes
Consistent with the SNS and EventBridge instrumentations in this repo, and with how
dd-trace-js and dd-trace-py build the same
_datadogpayload.Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: SLES-2981