Skip to content

fix sfn x-datadog-tags input - #12320

Open
ojproductions wants to merge 2 commits into
masterfrom
onzia/fix-sfn-tags
Open

fix sfn x-datadog-tags input#12320
ojproductions wants to merge 2 commits into
masterfrom
onzia/fix-sfn-tags

Conversation

@ojproductions

@ojproductions ojproductions commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

What Does This Do

Builds the _datadog object injected into the Step Functions StartExecution input
using the standard context propagator instead of hand-written JSON.

The payload now reflects the configured propagation styles, and x-datadog-tags is
the encoded _dd.p.* string rather than a JSON object of the client span's tags.

Motivation

x-datadog-tags is defined as a string. Emitting it as an object caused the Datadog
Lambda extension's Step Functions deserializer to reject the whole _datadog payload,
so trace context was dropped across the Step Functions boundary. The object also never
carried the propagated tags downstream consumers rely on (_dd.p.tid, _dd.p.dm) —
it exposed unrelated span tags instead — and sampling priority was not injected at all.

Additional Notes

Consistent with the SNS and EventBridge instrumentations in this repo, and with how
dd-trace-js and dd-trace-py build the same _datadog payload.

Contributor Checklist

Jira ticket: SLES-2981

@ojproductions ojproductions added comp: context propagation Trace context propagation type: bug fix Bug fix labels Aug 27, 2026
@ojproductions

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🎉

Reviewed commit: 3bb82d7eca

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@datadog-prod-us1-5

datadog-prod-us1-5 Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 69.74% (+10.95%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: e7f5aca | Docs | View more details | Give us feedback!

@ojproductions ojproductions added the inst: aws sdk AWS SDK instrumentation label Aug 27, 2026
@dd-octo-sts

dd-octo-sts Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.81 s 14.71 s [-0.2%; +1.5%] (no difference)
startup:insecure-bank:tracing:Agent 13.67 s 13.76 s [-1.6%; +0.4%] (no difference)
startup:petclinic:appsec:Agent 17.41 s 17.00 s [+1.4%; +3.5%] (significantly worse)
startup:petclinic:iast:Agent 17.46 s 17.52 s [-1.1%; +0.5%] (no difference)
startup:petclinic:profiling:Agent 17.32 s 17.33 s [-1.3%; +1.2%] (no difference)
startup:petclinic:sca:Agent 16.74 s 17.35 s [-7.7%; +0.7%] (no difference)
startup:petclinic:tracing:Agent 16.57 s 16.24 s [-2.4%; +6.4%] (no difference)

Commit: e7f5aca7 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@ojproductions
ojproductions marked this pull request as ready for review August 27, 2026 17:52
@ojproductions
ojproductions requested a review from a team as a code owner August 27, 2026 17:52
@ojproductions
ojproductions requested review from vandonr and removed request for a team August 27, 2026 17:52

@datadog-prod-us1-5 datadog-prod-us1-5 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

The configured propagator writes the required sampling priority and string-valued propagation tags without a reportable regression.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Datadog Autotest · Commit e7f5aca · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: context propagation Trace context propagation inst: aws sdk AWS SDK instrumentation type: bug fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant