Skip to content

Implement structural coverage cache for line level coverage #11924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
daniel-mohedano wants to merge 2 commits into from
Closed

Implement structural coverage cache for line level coverage #11924

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae7447c
feat: structural coverage cache
daniel-mohedano Jul 13, 2026
dac9e48
Add per-method probe-array swap to cut line-coverage recording overhead
daniel-mohedano Jul 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions ...ixtures/src/main/groovy/datadog/trace/civisibility/CiVisibilityInstrumentationTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ import datadog.trace.api.civisibility.config.LibraryCapability
import datadog.trace.api.civisibility.config.TestFQN
import datadog.trace.api.civisibility.config.TestIdentifier
import datadog.trace.api.civisibility.config.TestMetadata
import datadog.trace.api.civisibility.coverage.CoveragePerTestBridge
import datadog.trace.api.civisibility.events.TestEventsHandler
import datadog.trace.api.civisibility.telemetry.CiVisibilityMetricCollector
import datadog.trace.api.civisibility.telemetry.tag.Provider
Expand Down Expand Up @@ -201,8 +200,6 @@ abstract class CiVisibilityInstrumentationTest extends InstrumentationSpecificat
InstrumentationBridge.registerBuildEventsHandlerFactory {
decorator -> new BuildEventsHandlerImpl<>(buildSystemSessionFactory, new JvmInfoFactoryImpl())
}

CoveragePerTestBridge.registerCoverageStoreRegistry(coverageStoreFactory)
}

private static final class MockExecutionSettingsFactory implements ExecutionSettingsFactory {
Expand Down
2 changes: 0 additions & 2 deletions ...gent/agent-ci-visibility/src/main/java/datadog/trace/civisibility/CiVisibilitySystem.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
import datadog.trace.api.civisibility.DDTestSuite;
import datadog.trace.api.civisibility.InstrumentationBridge;
import datadog.trace.api.civisibility.config.LibraryCapability;
import datadog.trace.api.civisibility.coverage.CoveragePerTestBridge;
import datadog.trace.api.civisibility.events.BuildEventsHandler;
import datadog.trace.api.civisibility.events.TestEventsHandler;
import datadog.trace.api.civisibility.telemetry.CiVisibilityMetricCollector;
Expand Down Expand Up @@ -118,7 +117,6 @@ public static void start(Instrumentation inst, SharedCommunicationObjects sco) {
TestEventsHandlerFactory testEventsHandlerFactory =
new TestEventsHandlerFactory(services, repoServices, coverageServices, executionSettings);
InstrumentationBridge.registerTestEventsHandlerFactory(testEventsHandlerFactory);
CoveragePerTestBridge.registerCoverageStoreRegistry(coverageServices.coverageStoreFactory);

AgentTracer.TracerAPI tracerAPI = AgentTracer.get();
tracerAPI.addShutdownListener(testEventsHandlerFactory::shutdown);
Expand Down
5 changes: 0 additions & 5 deletions ...src/main/java/datadog/trace/civisibility/coverage/SkippableAwareCoverageStoreFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,4 @@ public CoverageStore create(@Nullable TestIdentifier testIdentifier) {
return delegate.create(testIdentifier);
}
}

@Override
public void setTotalProbeCount(String className, int totalProbeCount) {
delegate.setTotalProbeCount(className, totalProbeCount);
}
}
5 changes: 0 additions & 5 deletions ...-visibility/src/main/java/datadog/trace/civisibility/coverage/file/FileCoverageStore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,10 +118,5 @@ public CoverageStore create(@Nullable TestIdentifier testIdentifier) {
private FileProbes createProbes(boolean isTestThread) {
return new FileProbes(metrics, isTestThread);
}

@Override
public void setTotalProbeCount(String className, int totalProbeCount) {
// no op
}
}
}
5 changes: 0 additions & 5 deletions ...gent-ci-visibility/src/main/java/datadog/trace/civisibility/coverage/file/FileProbes.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,6 @@ public class FileProbes implements CoverageProbes {
nonCodeResources = isTestThread ? new HashMap<>() : new ConcurrentHashMap<>();
}

@Override
public void record(Class<?> clazz, long classId, int probeId) {
record(clazz);
}

@Override
public void record(Class<?> clazz) {
try {
Expand Down
Loading
Loading